mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 01:16:38 -06:00
DEV: Fix system test failure when ran in parallel (#21377)
What is the problem? The system tests incorrectly assumes that the discobot user which is seeded by a core plugin will always be present. This is not true as the discobot user will only be seeded when the test databases are migrated with plugins enabled. If we migrate test databases without plugins being enabled, the core system tests should still pass.
This commit is contained in:
parent
36c3a2422b
commit
9a3257cb33
@ -5,6 +5,11 @@ describe "User selector", type: :system, js: true do
|
||||
fab!(:post) { Fabricate(:post, topic: topic) }
|
||||
fab!(:current_user) { Fabricate(:admin) }
|
||||
|
||||
fab!(:user) do
|
||||
SearchIndexer.enable
|
||||
Fabricate(:user, username: "someone")
|
||||
end
|
||||
|
||||
before do
|
||||
current_user.activate
|
||||
sign_in(current_user)
|
||||
@ -14,11 +19,11 @@ describe "User selector", type: :system, js: true do
|
||||
it "correctly shows the user" do
|
||||
visit("/t/-/#{topic.id}")
|
||||
find(".btn-primary.create").click
|
||||
find(".d-editor-input").fill_in(with: "Hello @dis")
|
||||
find(".d-editor-input").fill_in(with: "Hello @som")
|
||||
|
||||
within(".autocomplete.ac-user") do |el|
|
||||
expect(el).to have_selector(".selected .avatar[title=discobot]")
|
||||
expect(el.find(".selected .username")).to have_content("discobot")
|
||||
expect(el).to have_selector(".selected .avatar[title=someone]")
|
||||
expect(el.find(".selected .username")).to have_content("someone")
|
||||
end
|
||||
end
|
||||
end
|
||||
|
Loading…
Reference in New Issue
Block a user