IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 09:26:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix system test failure when ran in parallel (#21377)

Browse Source 
What is the problem?

The system tests incorrectly assumes that the discobot user which is
seeded by a core plugin will always be present. This is not true as the
discobot user will only be seeded when the test databases are migrated
with plugins enabled. If we migrate test databases without plugins being
enabled, the core system tests should still pass.
This commit is contained in:
Alan Guo Xiang Tan 2023-05-04 08:24:50 +08:00 committed by GitHub
parent 36c3a2422b
commit 9a3257cb33
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
spec/system/user_selector_spec.rb
View File

@ -5,6 +5,11 @@ describe "User selector", type: :system, js: true do
fab!(:post) { Fabricate(:post, topic: topic) } fab!(:post) { Fabricate(:post, topic: topic) }
fab!(:current_user) { Fabricate(:admin) } fab!(:current_user) { Fabricate(:admin) }
fab!(:user) do
SearchIndexer.enable
Fabricate(:user, username: "someone")
end
before do before do
current_user.activate current_user.activate
sign_in(current_user) sign_in(current_user)
@ -14,11 +19,11 @@ describe "User selector", type: :system, js: true do
it "correctly shows the user" do it "correctly shows the user" do
visit("/t/-/#{topic.id}") visit("/t/-/#{topic.id}")
find(".btn-primary.create").click find(".btn-primary.create").click
find(".d-editor-input").fill_in(with: "Hello @dis") find(".d-editor-input").fill_in(with: "Hello @som")
within(".autocomplete.ac-user") do |el| within(".autocomplete.ac-user") do |el|
expect(el).to have_selector(".selected .avatar[title=discobot]") expect(el).to have_selector(".selected .avatar[title=someone]")
expect(el.find(".selected .username")).to have_content("discobot") expect(el.find(".selected .username")).to have_content("someone")
end end
end end
end end