DEV: introduce new API to look up dynamic site setting

This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup

This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class

It also removes a couple of risky stubs from the auth provider test
This commit is contained in:
Sam Saffron
2019-05-07 11:00:09 +10:00
parent 47995d2d89
commit 9be70a22cd
33 changed files with 99 additions and 73 deletions

View File

@@ -23,7 +23,7 @@ class Embedding < OpenStruct
def save
Embedding.settings.each do |s|
SiteSetting.send("#{s}=", send(s))
SiteSetting.set(s, public_send(s))
end
true
rescue Discourse::InvalidParameters => p