From 9cc99ef6db77d82b4af95911ee503e227cceae62 Mon Sep 17 00:00:00 2001 From: Sam Date: Sat, 25 Jan 2025 05:36:35 +1100 Subject: [PATCH] FIX: double click on tag INPUT breaking expected behavior (#30975) Double clicking on the INPUT for tag entry was cause the INPUT to be selected but the actual tag entry and lookup to be hidden This adds special case handling --- .../addon/components/select-kit/select-kit-header.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js b/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js index c4c3a628b6c..90841ada2db 100644 --- a/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js +++ b/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js @@ -76,7 +76,13 @@ export default class SelectKitHeader extends Component.extend(UtilsMixin) { ) { return false; } - this.selectKit.toggle(event); + + // When users double click on a tag input we want to leave it open + const hasInput = + event.target.tagName === "INPUT" || event.target.querySelector("input"); + if (!this.selectKit.isExpanded || !hasInput) { + this.selectKit.toggle(event); + } } keyUp(event) {