IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 08:57:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Do not show hidden posts in search results (#26800)

Browse Source
This commit is contained in:
Jan Cernik 2024-04-29 10:32:02 -05:00 committed by GitHub
parent f7a1272fa4
commit 9fb888923d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/search.rb
View File

@ -1076,7 +1076,7 @@ class Search
def posts_query(limit, type_filter: nil, aggregate_search: false)
posts =
Post.where(post_type: Topic.visible_post_types(@guardian.user)).joins(
Post.where(post_type: Topic.visible_post_types(@guardian.user), hidden: false).joins(
:post_search_data,
:topic,
)

7
spec/lib/search_spec.rb
View File

@ -1026,6 +1026,13 @@ RSpec.describe Search do
expect(results.posts).to eq([post])
end
it "does not return hidden posts" do
Fabricate(:post, raw: "Can you see me? I'm a hidden post", hidden: true)
results = Search.execute("hidden post")
expect(results.posts.count).to eq(0)
end
it "does not rely on postgres's proximity opreators" do
topic.update!(title: "End-to-end something something testing")