DEV - handle malformed page param (#11093)

* DEV - handle malformed page params
This commit is contained in:
jbrw
2020-11-02 12:40:54 -05:00
committed by GitHub
parent 03cd5baed9
commit 9ff7f25106
2 changed files with 25 additions and 3 deletions

View File

@@ -330,6 +330,21 @@ describe SearchController do
expect(response.status).to eq(400)
end
it "doesn't raise an error if the page is a string number" do
get "/search.json", params: { q: 'kittens', page: '3' }
expect(response.status).to eq(200)
end
it "doesn't raise an error if the page is a integer number" do
get "/search.json", params: { q: 'kittens', page: 3 }
expect(response.status).to eq(200)
end
it "returns a 400 error if the page parameter is invalid" do
get "/search.json?page=xawesome%27\"</a\&"
expect(response.status).to eq(400)
end
it "logs the search term" do
SiteSetting.log_search_queries = true
get "/search.json", params: { q: 'bantha' }