IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: De-arrowify tests (#11068)

Browse Source 
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
This commit is contained in:
Jarek Radosz
2020-10-30 17:37:32 +01:00
committed by GitHub
parent d5fb0b9435
commit a17d54d0bf
185 changed files with 762 additions and 762 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/tests/acceptance/personal-message-test.js
View File

@@ -8,7 +8,7 @@ import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Personal Message", function (needs) {
needs.user();
test("footer edit button", async (assert) => {
test("footer edit button", async function (assert) {
await visit("/t/pm-for-testing/12");
assert.ok(
@@ -17,7 +17,7 @@ acceptance("Personal Message", function (needs) {
);
});
test("suggested messages", async (assert) => {
test("suggested messages", async function (assert) {
await visit("/t/pm-for-testing/12");
assert.equal(