From a17fa222afff6e035d5b610487d6888896913d35 Mon Sep 17 00:00:00 2001
From: Kane York <kanepyork@gmail.com>
Date: Thu, 26 Mar 2020 11:17:31 -0700
Subject: [PATCH] DEV: Enable and fix link-href-attributes lint

---
 .template-lintrc.js                                           | 1 +
 .../discourse/templates/components/share-panel.hbs            | 2 +-
 .../discourse/templates/components/share-popup.hbs            | 2 +-
 app/assets/javascripts/discourse/templates/composer.hbs       | 4 ++--
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.template-lintrc.js b/.template-lintrc.js
index 32360e0a9e3..994a145b9bf 100644
--- a/.template-lintrc.js
+++ b/.template-lintrc.js
@@ -5,6 +5,7 @@ module.exports = {
   rules: {
     "deprecated-render-helper": true,
     "link-rel-noopener": true,
+    "link-href-attributes": true,
     "no-abstract-roles": true,
     "no-args-paths": true,
     "no-attrs-in-components": true,
diff --git a/app/assets/javascripts/discourse/templates/components/share-panel.hbs b/app/assets/javascripts/discourse/templates/components/share-panel.hbs
index 1808d6cc1f0..4a2b9935cf0 100644
--- a/app/assets/javascripts/discourse/templates/components/share-panel.hbs
+++ b/app/assets/javascripts/discourse/templates/components/share-panel.hbs
@@ -4,7 +4,7 @@
 
 <div class="body">
   {{textarea value=shareUrl class="topic-share-url"}}
-  <div class="topic-share-url-for-touch"><a></a></div>
+  <div class="topic-share-url-for-touch"><a href>{{! set by component }}</a></div>
 
   <div class="sources">
     {{#each sources as |source|}}
diff --git a/app/assets/javascripts/discourse/templates/components/share-popup.hbs b/app/assets/javascripts/discourse/templates/components/share-popup.hbs
index 54e8029cf67..38641694bdd 100644
--- a/app/assets/javascripts/discourse/templates/components/share-popup.hbs
+++ b/app/assets/javascripts/discourse/templates/components/share-popup.hbs
@@ -8,7 +8,7 @@
 
 <div>
   <input type="text">
-  <div class="share-for-touch"><div class="overflow-ellipsis"><a></a></div></div>
+  <div class="share-for-touch"><div class="overflow-ellipsis"><a href>{{! set by component }}</a></div></div>
 </div>
 
 <div class="actions">
diff --git a/app/assets/javascripts/discourse/templates/composer.hbs b/app/assets/javascripts/discourse/templates/composer.hbs
index 43af40a5274..f255cd5d4dc 100644
--- a/app/assets/javascripts/discourse/templates/composer.hbs
+++ b/app/assets/javascripts/discourse/templates/composer.hbs
@@ -191,7 +191,7 @@
 
               {{#if site.mobileView}}
                 {{#if allowUpload}}
-                  <a class="btn btn-default no-text mobile-file-upload {{if isUploading 'hidden'}}">
+                  <a href class="btn btn-default no-text mobile-file-upload {{if isUploading 'hidden'}}">
                     {{d-icon uploadIcon}}
                   </a>
                 {{/if}}
@@ -213,7 +213,7 @@
       {{else}}
         <div class='saving-text'>
           {{#if model.createdPost}}
-            {{i18n 'composer.saved'}} <a class='permalink' href={{createdPost.url}} {{action "viewNewReply"}}>{{i18n 'composer.view_new_post'}}</a>
+            {{i18n 'composer.saved'}} <a href class='permalink' href={{createdPost.url}} {{action "viewNewReply"}}>{{i18n 'composer.view_new_post'}}</a>
           {{else}}
             {{i18n 'composer.saving'}} {{loading-spinner size="small"}}
           {{/if}}