IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Refactor user_badge select_for_grouping scope (#13334)

Browse Source
This commit is contained in:
Mark VanLandingham 2021-06-08 13:37:42 -05:00 committed by GitHub
parent d500d0cc99
commit a27de199b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/models/user_badge.rb
View File

@ -7,6 +7,8 @@ class UserBadge < ActiveRecord::Base
belongs_to :notification, dependent: :destroy belongs_to :notification, dependent: :destroy
belongs_to :post belongs_to :post
BOOLEAN_ATTRIBUTES = %w(is_favorite)
scope :grouped_with_count, -> { scope :grouped_with_count, -> {
group(:badge_id, :user_id) group(:badge_id, :user_id)
.select_for_grouping .select_for_grouping
@ -17,11 +19,8 @@ class UserBadge < ActiveRecord::Base
scope :select_for_grouping, -> { scope :select_for_grouping, -> {
select( select(
UserBadge.attribute_names.map do |name| UserBadge.attribute_names.map do |name|
if name == 'is_favorite' operation = BOOLEAN_ATTRIBUTES.include?(name) ? "BOOL_OR" : "MAX"
"BOOL_OR(user_badges.#{name}) AS is_favorite" "#{operation}(user_badges.#{name}) AS #{name}"
else
"MAX(user_badges.#{name}) AS #{name}"
end
end, end,
'COUNT(*) AS "count"' 'COUNT(*) AS "count"'
) )