IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-07-29 15:54:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

FIX: do not log username change if the save process was unsuccessful

Browse Source
This commit is contained in:
Arpit Jalan
2019-05-13 22:20:27 +05:30
parent 5605dba85c
commit a2b1789c3e
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/services/username_changer.rb
+4 -4
View File
@@ -16,13 +16,13 @@ class UsernameChanger
end
def change(asynchronous: true, run_update_job: true)
if @actor && @old_username != @new_username
StaffActionLogger.new(@actor).log_username_change(@user, @old_username, @new_username)
end
@user.username = @new_username
if @user.save
if @actor && @old_username != @new_username
StaffActionLogger.new(@actor).log_username_change(@user, @old_username, @new_username)
end
UsernameChanger.update_username(user_id: @user.id,
old_username: @old_username,
new_username: @new_username,