IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: ability to restrict tags to categories using groups

Browse Source
This commit is contained in:
Neil Lalonde
2016-06-07 13:08:59 -04:00
parent f8051209ba
commit a49ace0ffb
16 changed files with 222 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spec/fabricators/tag_group_fabricator.rb Normal file
View File

@@ -0,0 +1,3 @@
Fabricator(:tag_group) do
name { sequence(:name) { |i| "tag_group_#{i}" } }
end

38
spec/integration/category_tag_spec.rb
View File

@@ -4,6 +4,11 @@ require 'rails_helper'
require_dependency 'post_creator'
describe "category tag restrictions" do
def sorted_tag_names(tag_records)
tag_records.map(&:name).sort
end
let!(:tag1) { Fabricate(:tag) }
let!(:tag2) { Fabricate(:tag) }
let!(:tag3) { Fabricate(:tag) }
@@ -57,4 +62,37 @@ describe "category tag restrictions" do
expect { other_category.update(allowed_tags: [tag1.name, 'tag-stuff', tag2.name, 'another-tag']) }.to change { Tag.count }.by(2)
end
end
context "tag groups restricted to a category" do
let!(:tag_group1) { Fabricate(:tag_group) }
let(:category) { Fabricate(:category) }
let(:other_category) { Fabricate(:category) }
before do
tag_group1.tags = [tag1, tag2]
end
it "tags in the group are used by category tag restrictions" do
category.allowed_tag_groups = [tag_group1.name]
category.reload
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true, category: category}))).to eq(sorted_tag_names([tag1, tag2]))
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true}))).to eq(sorted_tag_names([tag3, tag4]))
tag_group1.tags = [tag2, tag3, tag4]
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true, category: category}))).to eq(sorted_tag_names([tag2, tag3, tag4]))
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true}))).to eq(sorted_tag_names([tag1]))
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true, category: other_category}))).to eq(sorted_tag_names([tag1]))
end
it "groups and individual tags can be mixed" do
category.allowed_tag_groups = [tag_group1.name]
category.allowed_tags = [tag4.name]
category.reload
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true, category: category}))).to eq(sorted_tag_names([tag1, tag2, tag4]))
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true}))).to eq(sorted_tag_names([tag3]))
expect(sorted_tag_names(DiscourseTagging.filter_allowed_tags(Tag.all, Guardian.new(user), {for_input: true, category: other_category}))).to eq(sorted_tag_names([tag3]))
end
end
end