IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

A11Y: Return focus to header search button upon escape of search (#18656)

Browse Source
This commit is contained in:
Keegan George 2022-10-18 15:01:09 -07:00 committed by GitHub
parent 799fa8d6f9
commit a8af510636
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/app/widgets/search-menu.js
View File

@ -356,8 +356,9 @@ export default createWidget("search-menu", {
}, },
keyDown(e) { keyDown(e) {
if (e.which === 27 /* escape */) { if (e.key === "Escape") {
this.sendWidgetAction("toggleSearchMenu"); this.sendWidgetAction("toggleSearchMenu");
document.querySelector("#search-button").focus();
e.preventDefault(); e.preventDefault();
return false; return false;
} }

5
app/assets/javascripts/discourse/tests/acceptance/search-test.js
View File

@ -450,6 +450,11 @@ acceptance("Search - Authenticated", function (needs) {
); );
await triggerKeyEvent(".search-menu", "keydown", "Escape"); await triggerKeyEvent(".search-menu", "keydown", "Escape");
assert.strictEqual(
document.activeElement,
query("#search-button"),
"Escaping search returns focus to search button"
);
assert.ok(!exists(".search-menu:visible"), "Esc removes search dropdown"); assert.ok(!exists(".search-menu:visible"), "Esc removes search dropdown");
await click("#search-button"); await click("#search-button");