From a8f410a9c56c87b20449436a3b807955b8284b15 Mon Sep 17 00:00:00 2001 From: Vinoth Kannan Date: Wed, 17 Apr 2019 12:45:04 +0530 Subject: [PATCH] FEATURE: Create new helper method 'Discourse.stats' (#7388) --- lib/discourse.rb | 4 ++++ lib/s3_inventory.rb | 2 +- spec/components/s3_inventory_spec.rb | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/discourse.rb b/lib/discourse.rb index a6476dc5af6..f1c9f069d55 100644 --- a/lib/discourse.rb +++ b/lib/discourse.rb @@ -468,6 +468,10 @@ module Discourse end end + def self.stats + @stats ||= PluginStore.new("stats") + end + def self.current_user_provider @current_user_provider || Auth::DefaultCurrentUserProvider end diff --git a/lib/s3_inventory.rb b/lib/s3_inventory.rb index f6b053a27b2..8ec4ff5f451 100644 --- a/lib/s3_inventory.rb +++ b/lib/s3_inventory.rb @@ -65,7 +65,7 @@ class S3Inventory log "#{missing_count} of #{uploads.count} #{model.name.underscore.pluralize} are missing" end - $redis.set("missing_s3_#{model.table_name}", missing_count) + Discourse.stats.set("missing_s3_#{model.table_name}", missing_count) ensure connection.exec("DROP TABLE #{table_name}") unless connection.nil? end diff --git a/spec/components/s3_inventory_spec.rb b/spec/components/s3_inventory_spec.rb index bed034585a1..b6734641619 100644 --- a/spec/components/s3_inventory_spec.rb +++ b/spec/components/s3_inventory_spec.rb @@ -75,7 +75,7 @@ describe "S3Inventory" do end expect(output).to eq("#{upload.url}\n1 of 4 uploads are missing\n") - expect($redis.get("missing_s3_uploads")).to eq("1") + expect(Discourse.stats.get("missing_s3_uploads")).to eq(1) end it "should backfill etags to uploads table correctly" do