IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

REFACTOR: Always prefer to raise an error if record fails to save.

Browse Source
This commit is contained in:
Guo Xiang Tan 2018-03-13 12:01:01 +08:00
parent 1c208ef3f0
commit a9713ca20b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/email/receiver.rb
View File

@ -198,11 +198,11 @@ module Email
if user = User.find_by_email(email) if user = User.find_by_email(email)
user.user_stat.bounce_score += score user.user_stat.bounce_score += score
user.user_stat.reset_bounce_score_after = SiteSetting.reset_bounce_score_after_days.days.from_now user.user_stat.reset_bounce_score_after = SiteSetting.reset_bounce_score_after_days.days.from_now
user.user_stat.save user.user_stat.save!
bounce_score = user.user_stat.bounce_score bounce_score = user.user_stat.bounce_score
if user.active && bounce_score >= SiteSetting.bounce_score_threshold_deactivate if user.active && bounce_score >= SiteSetting.bounce_score_threshold_deactivate
user.update_columns(active: false) user.update!(active: false)
reason = I18n.t("user.deactivated", email: user.email) reason = I18n.t("user.deactivated", email: user.email)
StaffActionLogger.new(Discourse.system_user).log_user_deactivate(user, reason) StaffActionLogger.new(Discourse.system_user).log_user_deactivate(user, reason)
elsif bounce_score >= SiteSetting.bounce_score_threshold elsif bounce_score >= SiteSetting.bounce_score_threshold