IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 02:40:53 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: uses mod+p instead of ctrl+p and command+p for printTopic (#9202)

Browse Source 
Mousetrap 1.4 introduced a generic mod helper which lets you set cross platform shortcuts.

Mousetrap.bind('mod+p',  _print);
On Mac this ends up mapping to command+p whereas on Windows and Linux it maps to ctrl+p.

This differs from defining ctrl+p and command+p because both ctrl+p and command+p will trigger print on Mac whereas with the mod helper only command+p will.
This commit is contained in:
Joffrey JAFFEUX 2020-03-13 20:58:34 +01:00 committed by GitHub
parent 3723c64257
commit ac48c4e562
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/lib/keyboard-shortcuts.js
View File

@ -19,8 +19,7 @@ export let bindings = {
C: { handler: "focusComposer" },
"ctrl+f": { handler: "showPageSearch", anonymous: true },
"command+f": { handler: "showPageSearch", anonymous: true },
"ctrl+p": { handler: "printTopic", anonymous: true },
"command+p": { handler: "printTopic", anonymous: true },
"mod+p": { handler: "printTopic", anonymous: true },
d: { postAction: "deletePost" },
e: { postAction: "editPost" },
end: { handler: "goToLastPost", anonymous: true },