IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-07-29 15:54:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove SiteSetting.s3_force_path_style (#7210)

Browse Source 
- s3_force_path_style was added as a Minio specific url scheme but it has never been well supported in our code base.
- Our new migrate_to_s3 rake task does not work reliably with path style urls too
- Minio has also added support for virtual style requests i.e the same scheme as AWS S3/DO Spaces so we can rely on that instead of using path style requests.
- Add migration to drop s3_force_path_style from the site_settings table
This commit is contained in:
Rishabh
2019-03-20 14:58:20 +01:00
committed by Régis Hanol
parent f3d0d8fe7d
commit ad6ad3f679
6 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/discourse_defaults.conf
-1
View File
@@ -174,7 +174,6 @@ s3_secret_access_key =
s3_use_iam_profile = false
s3_cdn_url =
s3_endpoint =
s3_force_path_style =
### rate limits apply to all sites
max_user_api_reqs_per_minute = 20