DEV: Validate objects when updating typed objects theme settings (#25902)

Why this change?

This change ensures that we validate the value of the new objects
when updating typed objects theme settings.
This commit is contained in:
Alan Guo Xiang Tan
2024-02-28 10:33:22 +08:00
committed by GitHub
parent 42d203d773
commit afb0adf48d
4 changed files with 75 additions and 26 deletions
+1 -1
View File
@@ -6,7 +6,7 @@ class ThemeSettingsManager::Objects < ThemeSettingsManager
end
def value=(objects)
# TODO: Validate the objects against the schema
ensure_is_valid_value!(objects)
record = has_record? ? db_record : create_record!
record.json_value = objects
+1 -1
View File
@@ -61,7 +61,7 @@ class ThemeSettingsObjectValidator
end
def initialize(schema:, object:, json_pointer_prefix: "", errors: {}, valid_ids_lookup: {})
@object = object
@object = object.with_indifferent_access
@schema_name = schema[:name]
@properties = schema[:properties]
@errors = errors