IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: bookmark topic was not working intuitively

Browse Source 
- explicitly call out "clear bookmarks"
- correct keyboard shortcuts
- properly remove bookmarks when toggeling
This commit is contained in:
Sam
2015-02-19 10:58:57 +11:00
parent def034cd08
commit b041b3f67f
9 changed files with 125 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
config/locales/client.en.yml
View File

@@ -167,9 +167,10 @@ en:
bookmarked:
title: "Bookmark"
clear_bookmarks: "Clear Bookmarks"
help:
bookmark: "Click to bookmark this topic"
unbookmark: "Click to remove bookmark to this topic"
bookmark: "Click to bookmark the first post on this topic"
unbookmark: "Click to remove all bookmarks in this topic"
bookmarks:
not_logged_in: "sorry, you must be logged in to bookmark posts"
@@ -2287,7 +2288,7 @@ en:
dismiss_topics: '<b>x</b>, <b>t</b> Dismiss Topics'
actions:
title: 'Actions'
bookmark_topic: '<b>f</b> Bookmark topic'
bookmark_topic: '<b>f</b> Toggle bookmark topic'
pin_unpin_topic: '<b>shift</b>+<b>p</b> Pin/Unpin topic'
share_topic: '<b>shift</b>+<b>s</b> Share topic'
share_post: '<b>s</b> Share post'

1
config/routes.rb
View File

@@ -426,6 +426,7 @@ Discourse::Application.routes.draw do
post "t/:topic_id/change-owner" => "topics#change_post_owners", constraints: {topic_id: /\d+/}
delete "t/:topic_id/timings" => "topics#destroy_timings", constraints: {topic_id: /\d+/}
put "t/:topic_id/bookmark" => "topics#bookmark", constraints: {topic_id: /\d+/}
put "t/:topic_id/remove_bookmarks" => "topics#remove_bookmarks", constraints: {topic_id: /\d+/}
post "t/:topic_id/notifications" => "topics#set_notifications" , constraints: {topic_id: /\d+/}