IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Select correct topic draft for user (#15234)

Browse Source 
The old query could return multiple rows.
This commit is contained in:
Bianca Nenciu 2021-12-08 15:23:44 +02:00 committed by GitHub
parent 049bc33838
commit b1c11d5787
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/user_stat.rb
View File

@ -211,7 +211,7 @@ class UserStat < ActiveRecord::Base
UPDATE user_stats UPDATE user_stats
SET draft_count = (SELECT COUNT(*) FROM drafts WHERE user_id = :user_id) SET draft_count = (SELECT COUNT(*) FROM drafts WHERE user_id = :user_id)
WHERE user_id = :user_id WHERE user_id = :user_id
RETURNING draft_count, (SELECT 1 FROM drafts WHERE draft_key = :new_topic) RETURNING draft_count, (SELECT 1 FROM drafts WHERE user_id = :user_id AND draft_key = :new_topic)
SQL SQL
MessageBus.publish( MessageBus.publish(

2
spec/models/draft_spec.rb
View File

@ -179,6 +179,8 @@ describe Draft do
end end
it 'updates draft count when a draft is created or destroyed' do it 'updates draft count when a draft is created or destroyed' do
Draft.set(Fabricate(:user), Draft::NEW_TOPIC, 0, "data")
messages = MessageBus.track_publish("/user") do messages = MessageBus.track_publish("/user") do
Draft.set(user, Draft::NEW_TOPIC, 0, "data") Draft.set(user, Draft::NEW_TOPIC, 0, "data")
end end