From b22ea7911c3da85256a4504c1b39c6eff6af4e6f Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Fri, 19 Feb 2021 19:05:49 +0000
Subject: [PATCH] DEV: Drop old SSO site setting rows from the database
 (#12148)

These were copied to their new names in 821bb1e8cb72bee56cf5c2a878043112cc7ea2fd
---
 ...20210204135429_rename_sso_site_settings.rb |  2 +-
 ...210219171329_drop_old_sso_site_settings.rb | 35 +++++++++++++++++++
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 db/post_migrate/20210219171329_drop_old_sso_site_settings.rb

diff --git a/db/migrate/20210204135429_rename_sso_site_settings.rb b/db/migrate/20210204135429_rename_sso_site_settings.rb
index 8fb149b1ee1..a793e9fb807 100644
--- a/db/migrate/20210204135429_rename_sso_site_settings.rb
+++ b/db/migrate/20210204135429_rename_sso_site_settings.rb
@@ -25,7 +25,7 @@ class RenameSsoSiteSettings < ActiveRecord::Migration[6.0]
 
   def up
     # Copying the rows so that things keep working during deploy
-    # TODO: Add a post-deploy migration to drop the old rows
+    # They will be dropped in post_migrate/20210219171329_drop_old_sso_site_settings
 
     RENAME_SETTINGS.each do |old_name, new_name|
       execute <<~SQL
diff --git a/db/post_migrate/20210219171329_drop_old_sso_site_settings.rb b/db/post_migrate/20210219171329_drop_old_sso_site_settings.rb
new file mode 100644
index 00000000000..a201cfcd2ea
--- /dev/null
+++ b/db/post_migrate/20210219171329_drop_old_sso_site_settings.rb
@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+class DropOldSsoSiteSettings < ActiveRecord::Migration[6.0]
+  def up
+    # These were copied to their new names in migrate/20210204135429_rename_sso_site_settings
+    execute <<~SQL
+      DELETE FROM site_settings
+      WHERE name IN (
+        'enable_sso',
+        'sso_allows_all_return_paths',
+        'enable_sso_provider',
+        'verbose_sso_logging',
+        'sso_url',
+        'sso_secret',
+        'sso_provider_secrets',
+        'sso_overrides_groups',
+        'sso_overrides_bio',
+        'sso_overrides_email',
+        'sso_overrides_username',
+        'sso_overrides_name',
+        'sso_overrides_avatar',
+        'sso_overrides_profile_background',
+        'sso_overrides_location',
+        'sso_overrides_website',
+        'sso_overrides_card_background',
+        'external_auth_skip_create_confirm',
+        'external_auth_immediately'
+      )
+    SQL
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+end