IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Move badge grant_count updating to the UserBadge model callbacks.

Browse Source
This commit is contained in:
Vikhyat Korrapati 2014-06-17 20:41:52 +05:30
parent a68b47cb9f
commit b3f403952b
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/models/user_badge.rb
View File

@ -8,6 +8,14 @@ class UserBadge < ActiveRecord::Base
validates :user_id, presence: true validates :user_id, presence: true
validates :granted_at, presence: true validates :granted_at, presence: true
validates :granted_by, presence: true validates :granted_by, presence: true
after_create do
Badge.increment_counter 'grant_count', self.badge_id
end
after_destroy do
Badge.decrement_counter 'grant_count', self.badge_id
end
end end
# == Schema Information # == Schema Information

2
app/services/badge_granter.rb
View File

@ -19,7 +19,6 @@ class BadgeGranter
user_badge = UserBadge.create!(badge: @badge, user: @user, user_badge = UserBadge.create!(badge: @badge, user: @user,
granted_by: @granted_by, granted_at: Time.now) granted_by: @granted_by, granted_at: Time.now)
Badge.increment_counter 'grant_count', @badge.id
if @granted_by != Discourse.system_user if @granted_by != Discourse.system_user
StaffActionLogger.new(@granted_by).log_badge_grant(user_badge) StaffActionLogger.new(@granted_by).log_badge_grant(user_badge)
end end
@ -37,7 +36,6 @@ class BadgeGranter
def self.revoke(user_badge, options={}) def self.revoke(user_badge, options={})
UserBadge.transaction do UserBadge.transaction do
user_badge.destroy! user_badge.destroy!
Badge.decrement_counter 'grant_count', user_badge.badge_id
if options[:revoked_by] if options[:revoked_by]
StaffActionLogger.new(options[:revoked_by]).log_badge_revoke(user_badge) StaffActionLogger.new(options[:revoked_by]).log_badge_revoke(user_badge)
end end