From b58c965aad6867b94ee6007092d15321a19e2f94 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Tue, 26 Mar 2019 14:37:34 +0800 Subject: [PATCH] FIX: Destroy optimized image if attempting to migrate to new scheme fails. --- app/jobs/scheduled/migrate_upload_scheme.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/jobs/scheduled/migrate_upload_scheme.rb b/app/jobs/scheduled/migrate_upload_scheme.rb index 6be51da6995..21c33a171e5 100644 --- a/app/jobs/scheduled/migrate_upload_scheme.rb +++ b/app/jobs/scheduled/migrate_upload_scheme.rb @@ -26,9 +26,10 @@ module Jobs # migrate optimized_images to new scheme problems = OptimizedImage.migrate_to_new_scheme(50) + problems.each do |hash| - optimized_image_id = hash[:optimized_image].id - Discourse.handle_job_exception(hash[:ex], error_context(args, "Migrating optimized_image id #{optimized_image_id}", optimized_image_id: optimized_image_id)) + image = OptimizedImage.find_by(id: hash[:optimized_image].id) + image.destroy! if image end end