FIX: use full screen login for new-topic route (#7467)

DEV: add javascript tests for new-topic and new-message routes

DEV: fix an existing test that was being skipped

app/assets/javascripts/discourse.js.es6

@@ -11,7 +11,7 @@ const Discourse = Ember.Application.extend({
   _docTitle: document.title,
   RAW_TEMPLATES: {},
   __widget_helpers: {},
-  showingSignup: false,
+  useFullScreenLogin: false,
   customEvents: {
     paste: "paste"
   },

app/assets/javascripts/discourse/models/login-method.js.es6

@@ -93,7 +93,8 @@ export function findAll(siteSettings, capabilities, isMobileDevice) {
   // On Mobile, Android or iOS always go with full screen
   if (
     isMobileDevice ||
-    (capabilities && (capabilities.isIOS || capabilities.isAndroid))
+    (capabilities && (capabilities.isIOS || capabilities.isAndroid)) ||
+    Discourse.useFullScreenLogin
   ) {
     methods.forEach(m => m.set("full_screen_login", true));
   }

app/assets/javascripts/discourse/routes/new-message.js.es6

@@ -55,11 +55,8 @@ export default Discourse.Route.extend({
       });
     } else {
       $.cookie("destination_url", window.location.href);
-      if (Discourse.showingSignup) {
-        Discourse.showingSignup = false;
-      } else {
-        this.replaceWith("login");
-      }
+      Discourse.useFullScreenLogin = true;
+      this.replaceWith("login");
     }
   }
 });

app/assets/javascripts/discourse/routes/new-topic.js.es6

@@ -72,12 +72,8 @@ export default Discourse.Route.extend({
     } else {
       // User is not logged in
       $.cookie("destination_url", window.location.href);
-      if (Discourse.showingSignup) {
-        // We're showing the sign up modal
-        Discourse.showingSignup = false;
-      } else {
-        self.replaceWith("login");
-      }
+      Discourse.useFullScreenLogin = true;
+      self.replaceWith("login");
     }
   },