From b615201b886121c30547632acd04bf080d120706 Mon Sep 17 00:00:00 2001
From: Bianca Nenciu <nbianca@users.noreply.github.com>
Date: Fri, 30 Sep 2022 18:34:47 +0300
Subject: [PATCH] FIX: Remove zero-width space when not necessary (#18429)

A zero-width space character is inserted for icon-only buttons, but that
is unnecessary when the button has some rich-content and the block form
is used.
---
 .../javascripts/discourse/app/templates/components/d-button.hbs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/javascripts/discourse/app/templates/components/d-button.hbs b/app/assets/javascripts/discourse/app/templates/components/d-button.hbs
index e6586be8dd6..a05a03a3903 100644
--- a/app/assets/javascripts/discourse/app/templates/components/d-button.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/d-button.hbs
@@ -8,7 +8,7 @@
 
 {{~#if this.computedLabel~}}
   <span class="d-button-label">{{html-safe this.computedLabel}}{{#if this.ellipsis}}&hellip;{{/if}}</span>
-{{~else~}}
+{{~else if (not (has-block))~}}
   &#8203;
   {{! Zero-width space character, so icon-only button height = regular button height }}
 {{~/if~}}