IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

MODAL: Untangle onSelectPanel

Browse Source 
Previously modal-tab component would call on click the onSelectPanel callback with itself (modal-tab) as `this` which severely limited its usefulness. Now showModal binds the callback to its controller.
This commit is contained in:
Jarek Radosz 2020-07-04 14:09:55 +02:00
parent 126a1f550a
commit b7f6ec60c5
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/app/components/modal-tab.js
View File

@ -20,6 +20,10 @@ export default Component.extend({
},
click() {
this.onSelectPanel(this.panel);
this.set("selectedPanel", this.panel);
if (this.onSelectPanel) {
this.onSelectPanel(this.panel);
}
}
});

5
app/assets/javascripts/discourse/app/lib/show-modal.js
View File

@ -50,7 +50,10 @@ export default function(name, opts) {
});
if (controller.actions.onSelectPanel) {
modalController.set("onSelectPanel", controller.actions.onSelectPanel);
modalController.set(
"onSelectPanel",
controller.actions.onSelectPanel.bind(controller)
);
}
modalController.set(

4
app/assets/javascripts/discourse/app/mixins/modal-functionality.js
View File

@ -18,10 +18,6 @@ export default Mixin.create({
closeModal() {
this.modal.send("closeModal");
this.set("panels", []);
},
onSelectPanel(panel) {
this.set("selectedPanel", panel);
}
}
});