From bca8e1dbc65e9afb1c21a7cf0ec27836997d5bb1 Mon Sep 17 00:00:00 2001
From: Kris <kris.aubuchon@discourse.org>
Date: Tue, 22 Oct 2024 18:04:42 -0400
Subject: [PATCH] A11Y: Label site setting buttons (#29348)

---
 app/assets/javascripts/admin/addon/components/site-setting.hbs | 3 +++
 config/locales/client.en.yml                                   | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/app/assets/javascripts/admin/addon/components/site-setting.hbs b/app/assets/javascripts/admin/addon/components/site-setting.hbs
index 67f37c2325a..57f3394ba19 100644
--- a/app/assets/javascripts/admin/addon/components/site-setting.hbs
+++ b/app/assets/javascripts/admin/addon/components/site-setting.hbs
@@ -58,11 +58,13 @@
       @action={{this.update}}
       @icon="check"
       @disabled={{this.disableSaveButton}}
+      @ariaLabel="admin.settings.save"
       class="ok setting-controls__ok"
     />
     <DButton
       @action={{this.cancel}}
       @icon="xmark"
+      @ariaLabel="admin.settings.cancel"
       class="cancel setting-controls__cancel"
     />
   </div>
@@ -71,6 +73,7 @@
     <DButton
       @action={{this.toggleSecret}}
       @icon="far-eye-slash"
+      @ariaLabel="admin.settings.unmask"
       class="setting-toggle-secret"
     />
   {{/if}}
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 3af16cbe5b0..14f1a141340 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -6989,6 +6989,9 @@ en:
         history: "View change history"
         reset: "reset"
         none: "none"
+        save: "save"
+        cancel: "cancel"
+        unmask: "unmask input"
       site_settings:
         emoji_list:
           invalid_input: "Emoji list should only contain valid emoji names, eg: hugs"