IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: user got notified about a mention inside a chat message quote (#24229)

Browse Source 
When quoting a chat message in a post, if that message contains a mention, 
that mention should be ignored. But we've been detecting them and sending 
notifications to users. This PR fixes the problem. Since this fix is for 
the chat plugin, I had to introduce a new API for plugins:

    # We strip posts before detecting mentions, oneboxes, attachments etc. 
    # We strip those elements that shouldn't be detected. For example, 
    # a mention inside a quote should be ignored, so we strip it off. 
    # Using this API plugins can register their own post strippers. 
    def register_post_stripper(&block) 
    end
This commit is contained in:
Andrei Prigorshnev
2023-11-08 23:13:25 +04:00
committed by GitHub
parent 179abfca1a
commit be2eb3df44
6 changed files with 99 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/plugin/instance.rb
View File

@@ -1254,6 +1254,14 @@ class Plugin::Instance
DiscoursePluginRegistry.register_post_action_notify_user_handler(handler, self)
end
# We strip posts before detecting mentions, oneboxes, attachments etc.
# We strip those elements that shouldn't be detected. For example,
# a mention inside a quote should be ignored, so we strip it off.
# Using this API plugins can register their own post strippers.
def register_post_stripper(&block)
DiscoursePluginRegistry.register_post_stripper({ block: block }, self)
end
protected
def self.js_path