From be43d5153679c4dcadda6794c84fbe5463fe72a1 Mon Sep 17 00:00:00 2001 From: Jeff Atwood Date: Sat, 11 Oct 2014 03:46:42 -0700 Subject: [PATCH] remove admin-loading in favor of spinner css --- .../admin/templates/email_preview_digest.hbs | 2 +- .../javascripts/admin/templates/flags.hbs | 4 ++-- .../admin/templates/logs/screened_emails.hbs | 2 +- .../templates/logs/screened_ip_addresses.hbs | 2 +- .../admin/templates/logs/screened_urls.hbs | 2 +- .../admin/templates/logs/staff_action_logs.hbs | 2 +- .../javascripts/admin/templates/users_list.hbs | 2 +- .../stylesheets/common/admin/admin_base.scss | 18 ------------------ .../stylesheets/common/base/compose.scss | 2 ++ app/assets/stylesheets/desktop/compose.scss | 4 +--- 10 files changed, 11 insertions(+), 29 deletions(-) diff --git a/app/assets/javascripts/admin/templates/email_preview_digest.hbs b/app/assets/javascripts/admin/templates/email_preview_digest.hbs index dc3b946a843..abd414dbdc5 100644 --- a/app/assets/javascripts/admin/templates/email_preview_digest.hbs +++ b/app/assets/javascripts/admin/templates/email_preview_digest.hbs @@ -19,7 +19,7 @@ {{#if loading}} -
{{i18n loading}}
+
{{else}} {{#if showHtml}} {{{html_content}}} diff --git a/app/assets/javascripts/admin/templates/flags.hbs b/app/assets/javascripts/admin/templates/flags.hbs index 87a1af655a7..2b34210b598 100644 --- a/app/assets/javascripts/admin/templates/flags.hbs +++ b/app/assets/javascripts/admin/templates/flags.hbs @@ -9,7 +9,7 @@
{{#if loading}} -
{{i18n loading}}
+
{{else}} {{#if length}} @@ -160,7 +160,7 @@
{{#if view.loading}} -
{{i18n loading}}
+
{{/if}} {{else}} diff --git a/app/assets/javascripts/admin/templates/logs/screened_emails.hbs b/app/assets/javascripts/admin/templates/logs/screened_emails.hbs index d4e78bce6ac..68704f8ee00 100644 --- a/app/assets/javascripts/admin/templates/logs/screened_emails.hbs +++ b/app/assets/javascripts/admin/templates/logs/screened_emails.hbs @@ -1,7 +1,7 @@

{{i18n admin.logs.screened_emails.description}}

{{#if loading}} -
{{i18n loading}}
+
{{else}} {{#if model.length}} diff --git a/app/assets/javascripts/admin/templates/logs/screened_ip_addresses.hbs b/app/assets/javascripts/admin/templates/logs/screened_ip_addresses.hbs index 052bb46adab..042116be1f4 100644 --- a/app/assets/javascripts/admin/templates/logs/screened_ip_addresses.hbs +++ b/app/assets/javascripts/admin/templates/logs/screened_ip_addresses.hbs @@ -4,7 +4,7 @@
{{#if loading}} -
{{i18n loading}}
+
{{else}} {{#if model.length}} diff --git a/app/assets/javascripts/admin/templates/logs/screened_urls.hbs b/app/assets/javascripts/admin/templates/logs/screened_urls.hbs index 4753fb6c6b5..e20c57ed265 100644 --- a/app/assets/javascripts/admin/templates/logs/screened_urls.hbs +++ b/app/assets/javascripts/admin/templates/logs/screened_urls.hbs @@ -1,7 +1,7 @@

{{i18n admin.logs.screened_urls.description}}

{{#if loading}} -
{{i18n loading}}
+
{{else}} {{#if model.length}} diff --git a/app/assets/javascripts/admin/templates/logs/staff_action_logs.hbs b/app/assets/javascripts/admin/templates/logs/staff_action_logs.hbs index 8788b2000a8..9216c394af2 100644 --- a/app/assets/javascripts/admin/templates/logs/staff_action_logs.hbs +++ b/app/assets/javascripts/admin/templates/logs/staff_action_logs.hbs @@ -45,7 +45,7 @@ {{#if loading}}
-
{{i18n loading}}
+
{{else}} {{#if model.length}} {{view "staff-action-logs-list" content=controller}} diff --git a/app/assets/javascripts/admin/templates/users_list.hbs b/app/assets/javascripts/admin/templates/users_list.hbs index aca1ba0f2ee..dfdbe3c7f54 100644 --- a/app/assets/javascripts/admin/templates/users_list.hbs +++ b/app/assets/javascripts/admin/templates/users_list.hbs @@ -32,7 +32,7 @@
{{#if loading}} -
{{i18n loading}}
+
{{else}} {{#if model.length}} diff --git a/app/assets/stylesheets/common/admin/admin_base.scss b/app/assets/stylesheets/common/admin/admin_base.scss index 55a0fc524f7..a94cbb0e00c 100644 --- a/app/assets/stylesheets/common/admin/admin_base.scss +++ b/app/assets/stylesheets/common/admin/admin_base.scss @@ -66,24 +66,6 @@ td.flaggers td { } } -.admin-loading { - width: 100px; - margin: 0 auto 30px auto; - background-color: #000; - @include border-radius-all(10px); - padding: 10px 10px 10px 30px; - font-size: 15px; - line-height: 23px; - text-align: center; - color: $secondary; - background: { - image: image-url("spinner_96_w.gif"); - repeat: no-repeat; - position: 10px 8px; - size: 25px; - }; -} - .ip-lookup { position: relative; display: inline-block; diff --git a/app/assets/stylesheets/common/base/compose.scss b/app/assets/stylesheets/common/base/compose.scss index d0e00e0a603..381e96113af 100644 --- a/app/assets/stylesheets/common/base/compose.scss +++ b/app/assets/stylesheets/common/base/compose.scss @@ -134,3 +134,5 @@ div.ac-wrap { } } } + + diff --git a/app/assets/stylesheets/desktop/compose.scss b/app/assets/stylesheets/desktop/compose.scss index 464b0d1db3e..152c91dd8e9 100644 --- a/app/assets/stylesheets/desktop/compose.scss +++ b/app/assets/stylesheets/desktop/compose.scss @@ -181,7 +181,6 @@ .spinner { position: absolute; @include fades-in(0.25s); - @include border-radius-all(10px); left: 250px; top: 95px; height: 100px; @@ -189,8 +188,7 @@ height: 70px; text-indent: -9999em; background: { - color: #000; - image: image-url("spinner_96_w.gif"); + image: image-url("spinner_96.gif"); repeat: no-repeat; size: 35px; position: 17px 17px;