From bf2059baf5c7b7bef24efc1ebc716962e71d851f Mon Sep 17 00:00:00 2001
From: Vinoth Kannan <vinothkannan@vinkas.com>
Date: Tue, 19 Feb 2019 13:14:06 +0530
Subject: [PATCH] SPEC: check enqueued jobs size instead of using mocks

---
 spec/models/web_hook_spec.rb | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/spec/models/web_hook_spec.rb b/spec/models/web_hook_spec.rb
index f424cb0033a..89beb7042d0 100644
--- a/spec/models/web_hook_spec.rb
+++ b/spec/models/web_hook_spec.rb
@@ -125,13 +125,20 @@ describe WebHook do
     end
 
     describe 'when there are no active hooks' do
-      it 'should not generate payload and enqueue anything' do
+      it 'should not generate payload and enqueue anything for topic events' do
         topic_web_hook.destroy!
         post = PostCreator.create(user, raw: 'post', title: 'topic', skip_validations: true)
         expect(Jobs::EmitWebHookEvent.jobs.length).to eq(0)
 
         WebHook.expects(:generate_payload).times(0)
         PostDestroyer.new(admin, post).destroy
+        expect(Jobs::EmitWebHookEvent.jobs.length).to eq(0)
+      end
+
+      it 'should not enqueue anything for tag events' do
+        tag = Fabricate(:tag)
+        tag.destroy!
+        expect(Jobs::EmitWebHookEvent.jobs.length).to eq(0)
       end
     end
 
@@ -387,12 +394,6 @@ describe WebHook do
       expect(payload["id"]).to eq(tag.id)
     end
 
-    it 'should not generate payload if webhooks not exist' do
-      WebHook.expects(:generate_payload).times(0)
-      tag = Fabricate(:tag)
-      tag.destroy!
-    end
-
     it 'should enqueue the right hooks for flag events' do
       post = Fabricate(:post)
       admin = Fabricate(:admin)