From c0cd109e9d8d6b5b1cdaf41785c1a6c6c29e152b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9gis=20Hanol?= <regis@hanol.fr>
Date: Thu, 26 Jun 2014 19:50:16 +0200
Subject: [PATCH] TRIVIAL: code formatting

---
 app/controllers/user_avatars_controller.rb | 4 +---
 app/models/user.rb                         | 2 +-
 app/models/user_avatar.rb                  | 2 +-
 lib/tasks/avatars.rake                     | 5 +++++
 4 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/controllers/user_avatars_controller.rb b/app/controllers/user_avatars_controller.rb
index 9fbb97d51bd..26bc809d365 100644
--- a/app/controllers/user_avatars_controller.rb
+++ b/app/controllers/user_avatars_controller.rb
@@ -48,9 +48,7 @@ class UserAvatarsController < ApplicationController
     return render_dot unless user = User.find_by(username_lower: username.downcase)
 
     size = params[:size].to_i
-    if size > 1000 || size < 1
-      return render_dot
-    end
+    return render_dot if size > 1000 || size < 1
 
     image = nil
     version = params[:version].to_i
diff --git a/app/models/user.rb b/app/models/user.rb
index e71d6988a70..6c177f71780 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -603,7 +603,7 @@ class User < ActiveRecord::Base
       gravatar_downloaded = avatar.gravatar_upload_id
     end
 
-    if (!self.uploaded_avatar_id && gravatar_downloaded)
+    if !self.uploaded_avatar_id && gravatar_downloaded
       self.update_column(:uploaded_avatar_id, avatar.gravatar_upload_id)
     end
 
diff --git a/app/models/user_avatar.rb b/app/models/user_avatar.rb
index 354d9737725..9e0c9905c9c 100644
--- a/app/models/user_avatar.rb
+++ b/app/models/user_avatar.rb
@@ -34,7 +34,7 @@ class UserAvatar < ActiveRecord::Base
     # skip saving, we are not connected to the net
     Rails.logger.warn "Failed to download gravatar, socket error - user id #{ user.id }"
   ensure
-    tempfile.unlink if tempfile
+    tempfile.close! if tempfile && tempfile.respond_to?(:close!)
   end
 
 end
diff --git a/lib/tasks/avatars.rake b/lib/tasks/avatars.rake
index 9616a85def9..d561d7987ee 100644
--- a/lib/tasks/avatars.rake
+++ b/lib/tasks/avatars.rake
@@ -1,19 +1,23 @@
 desc "Refresh all avatars (download missing gravatars, refresh system)"
 task "avatars:refresh" => :environment do
   i = 0
+
   puts "Refreshing avatars"
   puts
+
   User.find_each do |user|
     user.refresh_avatar
     user.user_avatar.update_gravatar!
     putc "." if (i += 1) % 10 == 0
   end
+
   puts
 end
 
 desc "Clean up all avatar thumbnails (use this when the thumbnail algorithm changes)"
 task "avatars:clean" => :environment do
   i = 0
+
   puts "Cleaning up avatar thumbnails"
   puts
 
@@ -24,5 +28,6 @@ task "avatars:clean" => :environment do
     optimized_image.destroy!
     putc "." if (i += 1) % 10 == 0
   end
+
   puts
 end