IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Convert assert.true(exists()) to qunit-dom (#29638)

Browse Source
This commit is contained in:
Jarek Radosz
2024-11-08 20:27:32 +01:00
committed by GitHub
parent 3a23ff98bc
commit c1916f7984
20 changed files with 101 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/tests/acceptance/composer-messages-test.js
View File

@@ -47,7 +47,7 @@ acceptance("Composer - Messages", function (needs) {
await triggerKeyEvent(".d-editor-input", "keyup", "Space");
assert.true(exists(".composer-popup"), "shows composer warning message");
assert.dom(".composer-popup").exists("shows composer warning message");
assert.true(
query(".composer-popup").innerHTML.includes(
@@ -101,7 +101,7 @@ acceptance("Composer - Messages - Cannot see group", function (needs) {
);
await fillIn(".d-editor-input", "Mention @staff");
assert.true(exists(".composer-popup"), "shows composer warning message");
assert.dom(".composer-popup").exists("shows composer warning message");
assert.true(
query(".composer-popup").innerHTML.includes(
I18n.t("composer.cannot_see_group_mention.not_allowed", {
@@ -121,7 +121,7 @@ acceptance("Composer - Messages - Cannot see group", function (needs) {
);
await fillIn(".d-editor-input", "Mention @staff2");
assert.true(exists(".composer-popup"), "shows composer warning message");
assert.dom(".composer-popup").exists("shows composer warning message");
assert.true(
query(".composer-popup").innerHTML.includes(
I18n.t("composer.cannot_see_group_mention.some_not_allowed", {
@@ -242,7 +242,7 @@ acceptance("Composer - Messages - Private Messages", function (needs) {
await triggerKeyEvent(".d-editor-input", "keyup", "Space");
assert.true(exists(".composer-popup"), "shows composer warning message");
assert.dom(".composer-popup").exists("shows composer warning message");
assert.true(
query(".composer-popup").innerHTML.includes(
I18n.t("composer.yourself_confirm.title")

7
app/assets/javascripts/discourse/tests/acceptance/sidebar-user-categories-section-test.js
View File

@@ -141,10 +141,9 @@ acceptance("Sidebar - Logged on user - Categories Section", function (needs) {
".sidebar-section[data-section-name='categories'] .sidebar-section-header-button"
);
assert.true(
exists(".sidebar-categories-form"),
"it shows the categories form modal"
);
assert
.dom(".sidebar-categories-form")
.exists("shows the categories form modal");
});
test("categories section is shown with site's top categories when user has not added any categories and there are no default categories set for the user", async function (assert) {

25
app/assets/javascripts/discourse/tests/integration/components/widgets/render-glimmer-test.js
View File

@@ -4,7 +4,6 @@ import { click, fillIn, render } from "@ember/test-helpers";
import { hbs } from "ember-cli-htmlbars";
import { module, test } from "qunit";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import { exists } from "discourse/tests/helpers/qunit-helpers";
import widgetHbs from "discourse/widgets/hbs-compiler";
import RenderGlimmer, {
registerWidgetShim,
@@ -169,8 +168,8 @@ module("Integration | Component | Widget | render-glimmer", function (hooks) {
<MountWidget @widget="demo-widget" @args={{hash arg1="val1" dynamicArg=this.dynamicValue}} />`
);
assert.true(exists("div.my-widget"), "widget is rendered");
assert.true(exists("div.glimmer-content"), "glimmer content is rendered");
assert.dom("div.my-widget").exists("widget is rendered");
assert.dom("div.glimmer-content").exists("glimmer content is rendered");
assert
.dom("div.glimmer-content")
.hasText("arg1=val1 dynamicArg=", "arguments are passed through");
@@ -200,9 +199,9 @@ module("Integration | Component | Widget | render-glimmer", function (hooks) {
{{/unless}}`
);
assert.true(exists("div.my-widget"), "widget is rendered");
assert.true(exists("div.glimmer-content"), "glimmer content is rendered");
assert.true(exists("div.demo-component"), "demo component is rendered");
assert.dom("div.my-widget").exists("widget is rendered");
assert.dom("div.glimmer-content").exists("glimmer content is rendered");
assert.dom("div.demo-component").exists("demo component is rendered");
assert.deepEqual(
DemoComponent.eventLog,
@@ -261,10 +260,9 @@ module("Integration | Component | Widget | render-glimmer", function (hooks) {
{{/unless}}`
);
assert.true(
exists("div.demo-component button"),
"component button is rendered"
);
assert
.dom("div.demo-component button")
.exists("component button is rendered");
await click("div.demo-component button");
assert.true(DemoWidget.actionTriggered, "widget event is triggered");
@@ -284,10 +282,9 @@ module("Integration | Component | Widget | render-glimmer", function (hooks) {
.dom(".action-state")
.hasText("false", "eventTriggered is false in nested component");
assert.true(
exists("div.demo-component button"),
"component button is rendered"
);
assert
.dom("div.demo-component button")
.exists("component button is rendered");
await click("div.demo-component button");
assert.true(DemoWidget.actionTriggered, "widget event is triggered");