From c1bf707e7d89d4e20824738112e595ae928383a6 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Mon, 19 Mar 2018 14:36:09 +0800 Subject: [PATCH] PERF: N+1 queries on badges page. --- app/controllers/badges_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/badges_controller.rb b/app/controllers/badges_controller.rb index 7b11f789206..902f3bfc3d5 100644 --- a/app/controllers/badges_controller.rb +++ b/app/controllers/badges_controller.rb @@ -14,8 +14,8 @@ class BadgesController < ApplicationController if (params[:only_listable] == "true") || !request.xhr? # NOTE: this is sorted client side if needed badges = badges.includes(:badge_grouping) + .includes(:badge_type) .where(enabled: true, listable: true) - end badges = badges.to_a