FIX: Reviewables should not be created for users until they are active

Conversely, if a user is deactivated the reviewable should automatically
be rejected.

Before this fix, if a user was not active they'd still show in the
review queue but without an "Approve" button which was confusing.
This commit is contained in:
Robin Ward
2019-04-03 12:04:05 -04:00
parent 974007a3cc
commit c1ea63bdc1
13 changed files with 82 additions and 17 deletions

View File

@@ -310,7 +310,7 @@ class Admin::UsersController < Admin::AdminController
def deactivate
guardian.ensure_can_deactivate!(@user)
@user.deactivate
@user.deactivate(current_user)
StaffActionLogger.new(current_user).log_user_deactivate(@user, I18n.t('user.deactivated_by_staff'), params.slice(:context))
refresh_browser @user
render body: nil