From c467d7f691b17955cccfb4b7940027b4a6146b90 Mon Sep 17 00:00:00 2001
From: JSey <joerg.seyfried@gmail.com>
Date: Tue, 28 Oct 2014 20:02:33 +0100
Subject: [PATCH] BUG: phpBB lists not properly converted

bbcode-to-md happily ignores all phpBB's lists. The list syntax is
    [list][*]item 1
    [*]item 2
    [/list]
and
    [list=1][*]item 1
    [*]item 2
    [/list]
respectively for [ul] and [ol]s. Luckily, phpBB adds closing tags for [*] items. My workaround simply converts phpBBs lists into bbcode using [ul] and [ol] which then can be converted by the standard bbcode-to-md code.
---
 script/import_scripts/phpbb3.rb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/script/import_scripts/phpbb3.rb b/script/import_scripts/phpbb3.rb
index 234113362c3..01f80f7feb4 100644
--- a/script/import_scripts/phpbb3.rb
+++ b/script/import_scripts/phpbb3.rb
@@ -10,7 +10,7 @@ class ImportScripts::PhpBB3 < ImportScripts::Base
 
   include ActionView::Helpers::NumberHelper
 
- PHPBB_DB   = "phpbb"
+  PHPBB_DB   = "phpbb"
   BATCH_SIZE = 1000
 
   ORIGINAL_SITE_PREFIX = "oldsite.example.com/forums" # without http(s)://
@@ -306,7 +306,13 @@ class ImportScripts::PhpBB3 < ImportScripts::Base
     s.gsub!(internal_url_regexp) do |phpbb_link|
       replace_internal_link(phpbb_link, $1, import_id)
     end
-
+    # convert list tags to ul and list=1 tags to ol
+    # (basically, we're only missing list=a here...)
+    s.gsub!(/\[list\](.*?)\[\/list:u\]/m, '[ul]\1[/ul]')
+    s.gsub!(/\[list=1\](.*?)\[\/list:o\]/m, '[ol]\1[/ol]')
+    # convert *-tags to li-tags so bbcode-to-md can do its magic on phpBB's lists:
+    s.gsub!(/\[\*\](.*?)\[\/\*:m\]/, '[li]\1[/li]')
+    
     s
   end