Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.

2025-02-25 18:55:32 -06:00 · 2013-05-31 11:41:40 -04:00
parent 1e7279f0ea
commit c4904aacc0
20 changed files with 585 additions and 32 deletions
--- a/spec/integration/spam_rules_spec.rb
+++ b/spec/integration/spam_rules_spec.rb
@@ -0,0 +1,103 @@
+# encoding: UTF-8
+
+require 'spec_helper'
+
+describe PostAction do
+
+  before do
+    SiteSetting.flags_required_to_hide_post = 0 # never
+    SiteSetting.num_flags_to_block_new_user = 2
+    SiteSetting.num_users_to_block_new_user = 2
+  end
+
+  Given!(:admin)   { Fabricate(:admin) } # needed to send a system message
+  Given(:user1)    { Fabricate(:user) }
+  Given(:user2)    { Fabricate(:user) }
+
+  context 'spammer is a new user' do
+    Given(:spammer)  { Fabricate(:user, trust_level: TrustLevel.levels[:newuser]) }
+
+    context 'spammer post is not flagged enough times' do
+      Given!(:spam_post)  { Fabricate(:post, user: spammer) }
+      Given!(:spam_post2) { Fabricate(:post, user: spammer) }
+      When                { PostAction.act(user1, spam_post, PostActionType.types[:spam]) }
+      Then                { expect(spam_post.reload).to_not be_hidden }
+
+      context 'spam posts are flagged enough times, but not by enough users' do
+        When { PostAction.act(user1, spam_post2, PostActionType.types[:spam]) }
+        Then { expect(spam_post.reload).to_not be_hidden }
+        And  { expect(spam_post2.reload).to_not be_hidden }
+        And  { expect(spammer.reload).to_not be_blocked }
+      end
+
+      context 'one spam post is flagged enough times by enough users' do
+        Given!(:another_topic)          { Fabricate(:topic) }
+        Given!(:private_messages_count) { spammer.private_topics_count }
+
+        When { PostAction.act(user2, spam_post, PostActionType.types[:spam]) }
+
+        Invariant { expect(Guardian.new(spammer).can_create_topic?(nil)).to be_false }
+        Invariant { expect{PostCreator.create(spammer, {title: 'limited time offer for you', raw: 'better buy this stuff ok', archetype_id: 1})}.to raise_error(Discourse::InvalidAccess) }
+        Invariant { expect{PostCreator.create(spammer, {topic_id: another_topic.id, raw: 'my reply is spam in your topic', archetype_id: 1})}.to raise_error(Discourse::InvalidAccess) }
+
+        Then { expect(spammer.reload).to be_blocked }
+        And  { expect(spam_post.reload).to be_hidden }
+        And  { expect(spam_post2.reload).to be_hidden }
+        And  { expect(spammer.reload.private_topics_count).to eq(private_messages_count + 1) }
+
+
+        # The following cases describe when a staff user takes some action, but the user
+        # still won't be able to make posts.
+        # A staff user needs to clear the spam flag from the user record.
+
+        context "a post's flags are cleared" do
+          When { PostAction.clear_flags!(spam_post, admin); spammer.reload }
+          Then { expect(spammer.reload).to be_blocked }
+        end
+
+        context "a post is deleted" do
+          When { spam_post.trash!; spammer.reload }
+          Then { expect(spammer.reload).to be_blocked }
+        end
+
+        context "spammer becomes a basic user" do
+          When { spammer.change_trust_level!(:basic); spammer.reload }
+          Then { expect(spammer.reload).to be_blocked }
+        end
+      end
+
+      context 'flags_required_to_hide_post takes effect too' do
+        Given { SiteSetting.stubs(:flags_required_to_hide_post).returns(2) }
+        When  { PostAction.act(user2, spam_post, PostActionType.types[:spam]) }
+        Then  { expect(spammer.reload).to be_blocked }
+        And   { expect(Guardian.new(spammer).can_create_topic?(nil)).to be_false }
+      end
+    end
+  end
+
+  context "spammer has trust level basic" do
+    Given(:spammer)  { Fabricate(:user, trust_level: TrustLevel.levels[:basic]) }
+
+    context 'one spam post is flagged enough times by enough users' do
+      Given!(:spam_post)              { Fabricate(:post, user: spammer) }
+      Given!(:private_messages_count) { spammer.private_topics_count }
+      When { PostAction.act(user1, spam_post, PostActionType.types[:spam]) }
+      When { PostAction.act(user2, spam_post, PostActionType.types[:spam]) }
+      Then { expect(spam_post.reload).to_not be_hidden }
+      And  { expect(Guardian.new(spammer).can_create_topic?(nil)).to be_true }
+      And  { expect{PostCreator.create(spammer, {title: 'limited time offer for you', raw: 'better buy this stuff ok', archetype_id: 1})}.to_not raise_error }
+      And  { expect(spammer.reload.private_topics_count).to eq(private_messages_count) }
+    end
+  end
+
+  [[:user, trust_level: TrustLevel.levels[:regular]], [:admin], [:moderator]].each do |spammer_args|
+    context "spammer is trusted #{spammer_args[0]}" do
+      Given!(:spammer)                { Fabricate(*spammer_args) }
+      Given!(:spam_post)              { Fabricate(:post, user: spammer) }
+      Given!(:private_messages_count) { spammer.private_topics_count }
+      When { PostAction.act(user1, spam_post, PostActionType.types[:spam]) }
+      When { PostAction.act(user2, spam_post, PostActionType.types[:spam]) }
+      Then { expect(spam_post.reload).to_not be_hidden }
+    end
+  end
+end