mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FEATURE: Secure uploads in PMs only (#23398)
This adds a new secure_uploads_pm_only site setting. When secure_uploads is true with this setting, only uploads created in PMs will be marked secure; no uploads in secure categories will be marked as secure, and the login_required site setting has no bearing on upload security either. This is meant to be a stopgap solution to prevent secure uploads in a single place (private messages) for sensitive admin data exports. Ideally we would want a more comprehensive way of saying that certain upload types get secured which is a hybrid/mixed mode secure uploads, but for now this will do the trick.
This commit is contained in:
@@ -163,7 +163,7 @@ class UploadSecurity
|
||||
#### START PRIVATE CHECKS ####
|
||||
|
||||
def login_required_check
|
||||
SiteSetting.login_required?
|
||||
SiteSetting.login_required? && !SiteSetting.secure_uploads_pm_only?
|
||||
end
|
||||
|
||||
# Whether the upload should remain secure or not after posting depends on its context,
|
||||
|
||||
Reference in New Issue
Block a user