Unregister forum membership at Discourse Hub when deleting a user

lib/discourse_hub.rb

@@ -6,13 +6,13 @@ module DiscourseHub
   class NicknameUnavailable < RuntimeError; end
 
   def self.nickname_available?(nickname)
-    response = get('/users/nickname_available', {nickname: nickname})
-    [response['available'], response['suggestion']]
+    json = get('/users/nickname_available', {nickname: nickname})
+    [json['available'], json['suggestion']]
   end
 
   def self.nickname_match?(nickname, email)
-    response = get('/users/nickname_match', {nickname: nickname, email: email})
-    [response['match'], response['available'] || false, response['suggestion']]
+    json = get('/users/nickname_match', {nickname: nickname, email: email})
+    [json['match'], json['available'] || false, json['suggestion']]
   end
 
   def self.register_nickname(nickname, email)
@@ -24,6 +24,11 @@ module DiscourseHub
     end
   end
 
+  def self.unregister_nickname(nickname)
+    json = delete('/memberships/' + nickname)
+    json.has_key?('success')
+  end
+
   def self.change_nickname(current_nickname, new_nickname)
     json = put("/users/#{current_nickname}/nickname", {nickname: new_nickname})
     if json.has_key?('success')
@@ -46,18 +51,27 @@ module DiscourseHub
   private
 
   def self.get(rel_url, params={})
-    response = RestClient.get( "#{hub_base_url}#{rel_url}", {params: {access_token: access_token}.merge(params), accept: accepts } )
-    JSON.parse(response)
+    singular_action :get, rel_url, params
   end
 
   def self.post(rel_url, params={})
-    response = RestClient.post( "#{hub_base_url}#{rel_url}", {access_token: access_token}.merge(params), content_type: :json, accept: accepts )
-    JSON.parse(response)
+    collection_action :post, rel_url, params
   end
 
   def self.put(rel_url, params={})
-    response = RestClient.put( "#{hub_base_url}#{rel_url}", {access_token: access_token}.merge(params), content_type: :json, accept: accepts )
-    JSON.parse(response)
+    collection_action :put, rel_url, params
+  end
+
+  def self.delete(rel_url, params={})
+    singular_action :delete, rel_url, params
+  end
+
+  def self.singular_action(action, rel_url, params={})
+    JSON.parse RestClient.send(action, "#{hub_base_url}#{rel_url}", {params: {access_token: access_token}.merge(params), accept: accepts } )
+  end
+
+  def self.collection_action(action, rel_url, params={})
+    JSON.parse RestClient.send(action, "#{hub_base_url}#{rel_url}", {access_token: access_token}.merge(params), content_type: :json, accept: accepts )
   end
 
   def self.hub_base_url

lib/user_destroyer.rb

@@ -20,6 +20,7 @@ class UserDestroyer
       user.destroy.tap do |u|
         if u
           AdminLogger.new(@admin).log_user_deletion(user)
+          DiscourseHub.unregister_nickname(user.username)
           MessageBus.publish "/file-change", ["refresh"], user_ids: [user.id]
         end
       end