UX: Remove ring from avatar for a new user (#22780)

This commit is contained in:
Penar Musaraj 2023-07-25 14:49:44 -04:00 committed by GitHub
parent b91228d6c2
commit c6dca50ba4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 1 additions and 40 deletions

View File

@ -82,9 +82,7 @@ createWidget("header-notifications", {
if (user.isInDoNotDisturb()) { if (user.isInDoNotDisturb()) {
contents.push(h("div.do-not-disturb-background", iconNode("moon"))); contents.push(h("div.do-not-disturb-background", iconNode("moon")));
} else { } else {
let ringClass = null;
if (user.new_personal_messages_notifications_count) { if (user.new_personal_messages_notifications_count) {
ringClass = "personal-messages";
contents.push( contents.push(
this.attach("link", { this.attach("link", {
action: attrs.action, action: attrs.action,
@ -122,7 +120,6 @@ createWidget("header-notifications", {
}) })
); );
} else if (user.all_unread_notifications_count) { } else if (user.all_unread_notifications_count) {
ringClass = "regular-notifications";
contents.push( contents.push(
this.attach("link", { this.attach("link", {
action: attrs.action, action: attrs.action,
@ -137,9 +134,6 @@ createWidget("header-notifications", {
}) })
); );
} }
if (ringClass && this._shouldHighlightAvatar()) {
contents.push(h(`span.ring.revamped.${ringClass}`));
}
} }
return contents; return contents;
}, },

View File

@ -201,34 +201,6 @@
.notifications { .notifications {
position: relative; position: relative;
} }
.ring {
position: absolute;
top: -11px;
right: 23.5px;
z-index: z("base");
margin-left: 0;
border-radius: 100%;
width: 20px;
height: 20px;
box-shadow: 0 0 0 rgba(var(--success-rgb), 1);
transform: scale(1);
transform-origin: center;
animation-iteration-count: infinite;
animation-duration: 3s;
animation-name: ping;
&.revamped {
right: -4px;
top: -6px;
&.regular-notifications {
background: radial-gradient(
transparent,
var(--tertiary-med-or-tertiary)
);
}
}
}
.header-dropdown-toggle { .header-dropdown-toggle {
position: relative; position: relative;
} }
@ -259,8 +231,7 @@
.unread-notifications { .unread-notifications {
background-color: var(--tertiary-med-or-tertiary); background-color: var(--tertiary-med-or-tertiary);
} }
.unread-high-priority-notifications, .unread-high-priority-notifications {
.ring {
left: auto; left: auto;
right: 25px; right: 25px;
} }

View File

@ -23,7 +23,6 @@
@import "personal-message"; @import "personal-message";
@import "push-notifications-mobile"; @import "push-notifications-mobile";
@import "reviewables"; @import "reviewables";
@import "ring";
@import "search"; @import "search";
@import "tagging"; @import "tagging";
@import "topic-list"; @import "topic-list";

View File

@ -1,3 +0,0 @@
.ring {
top: -7px !important;
}