From c7d024446ef45e06eb4c16a279e248dcf643c776 Mon Sep 17 00:00:00 2001 From: Michael Howell Date: Thu, 16 Nov 2017 17:01:18 -0700 Subject: [PATCH] Cast the numeric keys of `USER_HOMES` to numbers (#5322) When converting from hard-coded functions to a map, the key `1` got converted to `"1"`. This broke the drop-down menu. --- .../discourse/controllers/preferences/interface.js.es6 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/controllers/preferences/interface.js.es6 b/app/assets/javascripts/discourse/controllers/preferences/interface.js.es6 index 18dccd86858..1b20fabe226 100644 --- a/app/assets/javascripts/discourse/controllers/preferences/interface.js.es6 +++ b/app/assets/javascripts/discourse/controllers/preferences/interface.js.es6 @@ -65,7 +65,7 @@ export default Ember.Controller.extend(PreferencesTabController, { @computed() userSelectableHome() { return _.map(USER_HOMES, (name, num) => { - return {name: I18n.t('filters.' + name + '.title'), value: num}; + return {name: I18n.t('filters.' + name + '.title'), value: Number(num)}; }); },