IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: skip hidden nodes when converting from HTML to Markdown

Browse Source
This commit is contained in:
Régis Hanol 2017-05-03 19:34:03 +02:00
parent 09cb61b533
commit c8044c6956
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/html_to_markdown.rb
View File

@ -37,6 +37,8 @@ class HtmlToMarkdown
end end
def visit(node) def visit(node)
return if node["style"] && node["style"][/display[[:space:]]*:[[:space:]]*none/]
if node.description&.block? && node.parent&.description&.block? && @stack[-1].markdown.size > 0 if node.description&.block? && node.parent&.description&.block? && @stack[-1].markdown.size > 0
block = @stack[-1].dup block = @stack[-1].dup
@markdown << format_block @markdown << format_block

4
spec/components/html_to_markdown_spec.rb
View File

@ -21,6 +21,10 @@ describe HtmlToMarkdown do
)).to eq("Hello,\n\nThis is the 1st paragraph.\n\nThis is another paragraph") )).to eq("Hello,\n\nThis is the 1st paragraph.\n\nThis is another paragraph")
end end
it "skips hidden tags" do
expect(html_to_markdown(%Q{<p>Hello <span style="display: none">cruel </span>World!</p>})).to eq("Hello World!")
end
it "converts <strong>" do it "converts <strong>" do
expect(html_to_markdown("<strong>Strong</strong>")).to eq("**Strong**") expect(html_to_markdown("<strong>Strong</strong>")).to eq("**Strong**")
expect(html_to_markdown("<strong>Str*ng</strong>")).to eq("__Str*ng__") expect(html_to_markdown("<strong>Str*ng</strong>")).to eq("__Str*ng__")