From c8d49a4d0acba2a48aefc391ef38d54f714f9685 Mon Sep 17 00:00:00 2001 From: Krzysztof Kotlarek Date: Wed, 14 May 2025 14:02:34 +0800 Subject: [PATCH] UX: split admin logo and fonts to separate pages (#32700) Before we had logo and fonts page merged together. Decided to split them. --- .../addon/components/admin-font-chooser.gjs | 4 +- .../addon/components/admin-fonts-form.gjs | 14 +- .../addon/components/admin-logo-form.gjs | 124 +++----- .../admin/addon/routes/admin-config-fonts.js | 8 + .../routes/admin-config-logo-and-fonts.js | 8 - .../admin/addon/routes/admin-config-logo.js | 8 + .../admin/addon/routes/admin-route-map.js | 3 +- .../admin/addon/templates/config-fonts.gjs | 29 ++ .../addon/templates/config-logo-and-fonts.gjs | 52 ---- .../admin/addon/templates/config-logo.gjs | 29 ++ .../modal/update-default-text-size.gjs | 8 +- .../app/lib/sidebar/admin-nav-map.js | 15 +- .../admin/config/fonts_controller.rb | 3 + config/locales/client.en.yml | 174 ++++++----- config/routes.rb | 3 +- docs/ADMIN-QUICK-START-GUIDE.md | 4 +- lib/svg_sprite.rb | 1 + spec/system/admin_fonts_spec.rb | 76 +++++ spec/system/admin_logo_and_fonts_spec.rb | 289 ------------------ spec/system/admin_logo_spec.rb | 207 +++++++++++++ .../components/admin_fonts_form.rb | 2 +- .../components/admin_logo_form.rb | 2 +- spec/system/page_objects/pages/admin_fonts.rb | 15 + spec/system/page_objects/pages/admin_logo.rb | 15 + .../pages/admin_logo_and_fonts.rb | 19 -- 25 files changed, 546 insertions(+), 566 deletions(-) create mode 100644 app/assets/javascripts/admin/addon/routes/admin-config-fonts.js delete mode 100644 app/assets/javascripts/admin/addon/routes/admin-config-logo-and-fonts.js create mode 100644 app/assets/javascripts/admin/addon/routes/admin-config-logo.js create mode 100644 app/assets/javascripts/admin/addon/templates/config-fonts.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-logo-and-fonts.gjs create mode 100644 app/assets/javascripts/admin/addon/templates/config-logo.gjs create mode 100644 spec/system/admin_fonts_spec.rb delete mode 100644 spec/system/admin_logo_and_fonts_spec.rb create mode 100644 spec/system/admin_logo_spec.rb create mode 100644 spec/system/page_objects/pages/admin_fonts.rb create mode 100644 spec/system/page_objects/pages/admin_logo.rb delete mode 100644 spec/system/page_objects/pages/admin_logo_and_fonts.rb diff --git a/app/assets/javascripts/admin/addon/components/admin-font-chooser.gjs b/app/assets/javascripts/admin/addon/components/admin-font-chooser.gjs index 55bc7f8d0ff..cfcd140554f 100644 --- a/app/assets/javascripts/admin/addon/components/admin-font-chooser.gjs +++ b/app/assets/javascripts/admin/addon/components/admin-font-chooser.gjs @@ -53,9 +53,9 @@ export default class AdminFontChooser extends Component { class="admin-fonts-form__more font" > {{#if this.showMoreFonts}} - {{i18n "admin.config.logo_and_fonts.fonts.form.less_fonts"}} + {{i18n "admin.config.fonts.form.fewer_fonts"}} {{else}} - {{i18n "admin.config.logo_and_fonts.fonts.form.more_fonts"}} + {{i18n "admin.config.fonts.form.more_fonts"}} {{/if}} diff --git a/app/assets/javascripts/admin/addon/components/admin-fonts-form.gjs b/app/assets/javascripts/admin/addon/components/admin-fonts-form.gjs index 62f848d23d0..28ccb57b59f 100644 --- a/app/assets/javascripts/admin/addon/components/admin-fonts-form.gjs +++ b/app/assets/javascripts/admin/addon/components/admin-fonts-form.gjs @@ -85,7 +85,7 @@ export default class AdminFontsForm extends Component { this.toasts.success({ duration: 3000, data: { - message: i18n("admin.config.logo_and_fonts.fonts.form.saved"), + message: i18n("admin.config.fonts.form.saved"), }, }); this.siteSettingChangeTracker.refreshPage({ @@ -121,7 +121,7 @@ export default class AdminFontsForm extends Component { > @@ -145,9 +141,7 @@ export default class AdminLogoForm extends Component { @@ -157,12 +151,8 @@ export default class AdminLogoForm extends Component { @@ -172,15 +162,9 @@ export default class AdminLogoForm extends Component { {{/if}} @@ -217,9 +193,7 @@ export default class AdminLogoForm extends Component { @@ -229,11 +203,9 @@ export default class AdminLogoForm extends Component { @@ -282,10 +248,10 @@ export default class AdminLogoForm extends Component {