From c972a31819f9d795bcf8f8f1fb3afff8a00f29ae Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Tue, 4 Jun 2024 15:16:24 +0200 Subject: [PATCH] DEV: Fix typos and formatting (#27320) --- .../discourse/app/lib/sidebar/custom-sections.js | 2 +- .../float-kit/addon/lib/d-menu-instance.js | 2 +- .../float-kit/addon/lib/d-tooltip-instance.js | 2 +- .../javascripts/float-kit/addon/services/toasts.js | 2 +- docs/CHANGELOG-JAVASCRIPT-PLUGIN-API.md | 14 +++++++------- spec/system/admin_dashboard_new_features_spec.rb | 2 +- .../navigation_menu_state_integration_spec.rb | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/app/assets/javascripts/discourse/app/lib/sidebar/custom-sections.js b/app/assets/javascripts/discourse/app/lib/sidebar/custom-sections.js index 1c66b8d0903..ede0078e9ee 100644 --- a/app/assets/javascripts/discourse/app/lib/sidebar/custom-sections.js +++ b/app/assets/javascripts/discourse/app/lib/sidebar/custom-sections.js @@ -39,7 +39,7 @@ export function addSidebarSection(func, panelKey) { if (!panel) { // eslint-disable-next-line no-console return console.warn( - `Error adding section to ${panelKey} because panel doens't exist. Check addSidebarPanel API.` + `Error adding section to ${panelKey} because panel doesn't exist. Check addSidebarPanel API.` ); } panel.sections.push( diff --git a/app/assets/javascripts/float-kit/addon/lib/d-menu-instance.js b/app/assets/javascripts/float-kit/addon/lib/d-menu-instance.js index 8a7ad299125..81411276713 100644 --- a/app/assets/javascripts/float-kit/addon/lib/d-menu-instance.js +++ b/app/assets/javascripts/float-kit/addon/lib/d-menu-instance.js @@ -19,7 +19,7 @@ export default class DMenuInstance extends FloatKitInstance { /** * Specifies whether the trigger for opening/closing the menu is detached from the menu itself. - * This is the case when a menu is trigger programmaticaly instead of through the component. + * This is the case when a menu is trigger programmatically instead of through the component. * @property {boolean} detachedTrigger - Tracks whether the trigger is detached, initially set to false. */ @tracked detachedTrigger = false; diff --git a/app/assets/javascripts/float-kit/addon/lib/d-tooltip-instance.js b/app/assets/javascripts/float-kit/addon/lib/d-tooltip-instance.js index 43ab8ec57e1..c16e6079930 100644 --- a/app/assets/javascripts/float-kit/addon/lib/d-tooltip-instance.js +++ b/app/assets/javascripts/float-kit/addon/lib/d-tooltip-instance.js @@ -17,7 +17,7 @@ export default class DTooltipInstance extends FloatKitInstance { /** * Specifies whether the trigger for opening/closing the tooltip is detached from the tooltip itself. - * This is the case when a tooltip is trigger programmaticaly instead of through the component. + * This is the case when a tooltip is trigger programmatically instead of through the component. * @property {boolean} detachedTrigger - Tracks whether the trigger is detached, initially set to false. */ @tracked detachedTrigger = false; diff --git a/app/assets/javascripts/float-kit/addon/services/toasts.js b/app/assets/javascripts/float-kit/addon/services/toasts.js index d1078724835..6121bb95300 100644 --- a/app/assets/javascripts/float-kit/addon/services/toasts.js +++ b/app/assets/javascripts/float-kit/addon/services/toasts.js @@ -110,7 +110,7 @@ export default class Toasts extends Service { } /** - * Close a toast. Any object containg a valid `id` property can be used as a toast parameter. + * Close a toast. Any object containing a valid `id` property can be used as a toast parameter. */ @action close(toast) { diff --git a/docs/CHANGELOG-JAVASCRIPT-PLUGIN-API.md b/docs/CHANGELOG-JAVASCRIPT-PLUGIN-API.md index bff260560c0..d8c0173cd15 100644 --- a/docs/CHANGELOG-JAVASCRIPT-PLUGIN-API.md +++ b/docs/CHANGELOG-JAVASCRIPT-PLUGIN-API.md @@ -9,11 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [1.32.0] - 2024-05-16 -- Adds `registerHomeLogoHrefCallback` which allows to set a callback to change the home logo URL. +- Added `registerHomeLogoHrefCallback` which allows to set a callback to change the home logo URL. ## [1.31.0] - 2024-04-22 -- Adds `addTopicAdminMenuButton` which allows to register a new button in the topic admin menu. +- Added `addTopicAdminMenuButton` which allows to register a new button in the topic admin menu. ## [1.30.0] - 2024-03-20 @@ -21,20 +21,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [1.29.0] - 2024-03-05 -- added `headerButtons` which allows for manipulation of the header butttons. This includes, adding, removing, or modifying the order of buttons. +- Added `headerButtons` which allows for manipulation of the header buttons. This includes, adding, removing, or modifying the order of buttons. ## [1.28.0] - 2024-02-21 -- added `headerIcons` which allows for manipulation of the header icons. This includes, adding, removing, or modifying the order of icons. +- Added `headerIcons` which allows for manipulation of the header icons. This includes, adding, removing, or modifying the order of icons. ## [1.27.0] - 2024-02-21 -- deprecated `addToHeaderIcons` in favor of `headerIcons` +- Deprecated `addToHeaderIcons` in favor of `headerIcons` ## [1.26.0] - 2024-02-21 -- Added `renderBeforeWrapperOutlet` which is used for rendering components before the content of wrapper plugin outlets -- Added `renderAfterWrapperOutlet` which is used for rendering components after the content of wrapper plugin outlets +- Added `renderBeforeWrapperOutlet` which is used for rendering components before the content of wrapper plugin outlets +- Added `renderAfterWrapperOutlet` which is used for rendering components after the content of wrapper plugin outlets ## [1.25.0] - 2024-02-05 diff --git a/spec/system/admin_dashboard_new_features_spec.rb b/spec/system/admin_dashboard_new_features_spec.rb index 23faa78dd17..05211f1c929 100644 --- a/spec/system/admin_dashboard_new_features_spec.rb +++ b/spec/system/admin_dashboard_new_features_spec.rb @@ -6,7 +6,7 @@ describe "Admin Dashboard New Features Page", type: :system do before { sign_in(admin) } - it "displays new features with screenshot taking precednce over emoji" do + it "displays new features with screenshot taking precedence over emoji" do DiscourseUpdates.stubs(:new_features).returns( [ { diff --git a/spec/system/navigation_menu_state_integration_spec.rb b/spec/system/navigation_menu_state_integration_spec.rb index fcbf346d41c..63c741d7233 100644 --- a/spec/system/navigation_menu_state_integration_spec.rb +++ b/spec/system/navigation_menu_state_integration_spec.rb @@ -39,7 +39,7 @@ describe "Navigation menu states", type: :system, js: true do expect(find(sidebar_navigation.header_toggle_css)).to have_css(".d-icon-discourse-sidebar") end - it "shows the hamburger menu and allows toggling it, which shows the MAIN_PANEL onls" do + it "shows the hamburger menu and allows toggling it, which shows the MAIN_PANEL only" do visit "/admin" expect(header_dropdown).to be_visible header_dropdown.open