From cb1210da35accc28649a6ef409c1ba5f21e1f46f Mon Sep 17 00:00:00 2001 From: Mark VanLandingham Date: Fri, 17 Sep 2021 13:06:31 -0500 Subject: [PATCH] DEV: Set composer upload btn selectors in component (#14324) --- .../discourse/app/components/composer-editor.js | 2 ++ .../javascripts/discourse/app/mixins/composer-upload.js | 8 +++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/app/components/composer-editor.js b/app/assets/javascripts/discourse/app/components/composer-editor.js index 0a625f4a1f6..f8d5282e628 100644 --- a/app/assets/javascripts/discourse/app/components/composer-editor.js +++ b/app/assets/javascripts/discourse/app/components/composer-editor.js @@ -90,6 +90,8 @@ export function cleanUpComposerUploadMarkdownResolver() { export default Component.extend(ComposerUpload, { classNameBindings: ["showToolbar:toolbar-visible", ":wmd-controls"], + fileUploadElementId: "file-uploader", + mobileFileUploaderId: "mobile-file-upload", shouldBuildScrollMap: true, scrollMap: null, processPreview: true, diff --git a/app/assets/javascripts/discourse/app/mixins/composer-upload.js b/app/assets/javascripts/discourse/app/mixins/composer-upload.js index 01ab335ddaf..7c5446c5b07 100644 --- a/app/assets/javascripts/discourse/app/mixins/composer-upload.js +++ b/app/assets/javascripts/discourse/app/mixins/composer-upload.js @@ -331,9 +331,11 @@ export default Mixin.create({ _bindMobileUploadButton() { if (this.site.mobileView) { - this.mobileUploadButton = document.getElementById("mobile-file-upload"); - this.mobileUploadButtonEventListener = function mobileButtonEventListener() { - document.getElementById("file-uploader").click(); + this.mobileUploadButton = document.getElementById( + this.mobileFileUploaderId + ); + this.mobileUploadButtonEventListener = () => { + document.getElementById(this.fileUploadElementId).click(); }; this.mobileUploadButton.addEventListener( "click",