mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Apply syntax_tree formatting to spec/*
This commit is contained in:
@@ -6,9 +6,7 @@ RSpec.describe BookmarksController do
|
||||
let(:bookmark_topic) { Fabricate(:topic) }
|
||||
let(:bookmark_user) { current_user }
|
||||
|
||||
before do
|
||||
sign_in(current_user)
|
||||
end
|
||||
before { sign_in(current_user) }
|
||||
|
||||
describe "#create" do
|
||||
it "rate limits creates" do
|
||||
@@ -16,41 +14,47 @@ RSpec.describe BookmarksController do
|
||||
RateLimiter.enable
|
||||
RateLimiter.clear_all!
|
||||
|
||||
post "/bookmarks.json", params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601
|
||||
}
|
||||
post "/bookmarks.json",
|
||||
params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601,
|
||||
}
|
||||
|
||||
expect(response.status).to eq(200)
|
||||
|
||||
post "/bookmarks.json", params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
}
|
||||
post "/bookmarks.json",
|
||||
params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
}
|
||||
expect(response.status).to eq(429)
|
||||
end
|
||||
|
||||
context "if the user reached the max bookmark limit" do
|
||||
before do
|
||||
SiteSetting.max_bookmarks_per_user = 1
|
||||
end
|
||||
before { SiteSetting.max_bookmarks_per_user = 1 }
|
||||
|
||||
it "returns failed JSON with a 400 error" do
|
||||
post "/bookmarks.json", params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601
|
||||
}
|
||||
post "/bookmarks.json", params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
}
|
||||
post "/bookmarks.json",
|
||||
params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601,
|
||||
}
|
||||
post "/bookmarks.json",
|
||||
params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
}
|
||||
|
||||
expect(response.status).to eq(400)
|
||||
user_bookmarks_url = "#{Discourse.base_url}/my/activity/bookmarks"
|
||||
expect(response.parsed_body['errors']).to include(
|
||||
I18n.t("bookmarks.errors.too_many", user_bookmarks_url: user_bookmarks_url, limit: SiteSetting.max_bookmarks_per_user)
|
||||
expect(response.parsed_body["errors"]).to include(
|
||||
I18n.t(
|
||||
"bookmarks.errors.too_many",
|
||||
user_bookmarks_url: user_bookmarks_url,
|
||||
limit: SiteSetting.max_bookmarks_per_user,
|
||||
),
|
||||
)
|
||||
end
|
||||
end
|
||||
@@ -62,26 +66,28 @@ RSpec.describe BookmarksController do
|
||||
end
|
||||
|
||||
it "returns failed JSON with a 400 error" do
|
||||
post "/bookmarks.json", params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601
|
||||
}
|
||||
post "/bookmarks.json",
|
||||
params: {
|
||||
bookmarkable_id: bookmark_post.id,
|
||||
bookmarkable_type: "Post",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601,
|
||||
}
|
||||
|
||||
expect(response.status).to eq(400)
|
||||
expect(response.parsed_body['errors']).to include(
|
||||
I18n.t("bookmarks.errors.already_bookmarked", type: "Post")
|
||||
expect(response.parsed_body["errors"]).to include(
|
||||
I18n.t("bookmarks.errors.already_bookmarked", type: "Post"),
|
||||
)
|
||||
|
||||
post "/bookmarks.json", params: {
|
||||
bookmarkable_id: bookmark_topic.id,
|
||||
bookmarkable_type: "Topic",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601
|
||||
}
|
||||
post "/bookmarks.json",
|
||||
params: {
|
||||
bookmarkable_id: bookmark_topic.id,
|
||||
bookmarkable_type: "Topic",
|
||||
reminder_at: (Time.zone.now + 1.day).iso8601,
|
||||
}
|
||||
|
||||
expect(response.status).to eq(400)
|
||||
expect(response.parsed_body['errors']).to include(
|
||||
I18n.t("bookmarks.errors.already_bookmarked", type: "Topic")
|
||||
expect(response.parsed_body["errors"]).to include(
|
||||
I18n.t("bookmarks.errors.already_bookmarked", type: "Topic"),
|
||||
)
|
||||
end
|
||||
end
|
||||
@@ -99,7 +105,12 @@ RSpec.describe BookmarksController do
|
||||
delete "/bookmarks/#{bookmark.id}.json"
|
||||
expect(Bookmark.find_by(id: bookmark.id)).to eq(nil)
|
||||
expect(response.parsed_body["topic_bookmarked"]).to eq(false)
|
||||
bm2 = Fabricate(:bookmark, user: bookmark_user, bookmarkable: Fabricate(:post, topic: bookmark_post.topic))
|
||||
bm2 =
|
||||
Fabricate(
|
||||
:bookmark,
|
||||
user: bookmark_user,
|
||||
bookmarkable: Fabricate(:post, topic: bookmark_post.topic),
|
||||
)
|
||||
bm3 = Fabricate(:bookmark, user: bookmark_user, bookmarkable: bookmark_post.topic)
|
||||
delete "/bookmarks/#{bm2.id}.json"
|
||||
expect(Bookmark.find_by(id: bm2.id)).to eq(nil)
|
||||
@@ -115,9 +126,7 @@ RSpec.describe BookmarksController do
|
||||
delete "/bookmarks/#{bookmark.id}.json"
|
||||
|
||||
expect(response.status).to eq(404)
|
||||
expect(response.parsed_body['errors'].first).to include(
|
||||
I18n.t("not_found")
|
||||
)
|
||||
expect(response.parsed_body["errors"].first).to include(I18n.t("not_found"))
|
||||
end
|
||||
end
|
||||
|
||||
@@ -128,9 +137,7 @@ RSpec.describe BookmarksController do
|
||||
delete "/bookmarks/#{bookmark.id}.json"
|
||||
|
||||
expect(response.status).to eq(403)
|
||||
expect(response.parsed_body['errors'].first).to include(
|
||||
I18n.t("invalid_access")
|
||||
)
|
||||
expect(response.parsed_body["errors"].first).to include(I18n.t("invalid_access"))
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user