From cba3942850bea96effeaa6dec19bcf21fac7dc20 Mon Sep 17 00:00:00 2001
From: Guo Xiang Tan <tgx_world@hotmail.com>
Date: Mon, 21 May 2018 11:37:16 +0800
Subject: [PATCH] Refactor `WebHookFlagSerializer`.

---
 app/serializers/web_hook_flag_serializer.rb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/app/serializers/web_hook_flag_serializer.rb b/app/serializers/web_hook_flag_serializer.rb
index 67674fef8ef..847ae810e3d 100644
--- a/app/serializers/web_hook_flag_serializer.rb
+++ b/app/serializers/web_hook_flag_serializer.rb
@@ -8,7 +8,7 @@ class WebHookFlagSerializer < ApplicationSerializer
              :resolved_by
 
   def post
-    BasicPostSerializer.new(object.post, scope: scope, root: false).as_json
+    WebHookPostSerializer.new(object.post, scope: scope, root: false).as_json
   end
 
   def flag_type
@@ -32,9 +32,7 @@ class WebHookFlagSerializer < ApplicationSerializer
   end
 
   def resolved_by
-    if object.disposed_by_id.present?
-      User.find(object.disposed_by_id).username
-    end
+    User.find(object.disposed_by_id).username
   end
 
   def include_resolved_by?