Refactor FileHelper to use keyword arguments.

2025-02-25 18:55:32 -06:00 · 2017-05-24 13:42:52 -04:00
parent 87ac758f05
commit cdbe027c1c
12 changed files with 81 additions and 15 deletions
--- a/app/models/upload.rb
+++ b/app/models/upload.rb
@@ -93,7 +93,12 @@ class Upload < ActiveRecord::Base
          # download if external
          if external
            url = SiteSetting.scheme + ":" + previous_url
-            file = FileHelper.download(url, max_file_size_kb, "discourse", true) rescue nil
+            file = FileHelper.download(
+              url,
+              max_file_size: max_file_size_kb,
+              tmp_file_name: "discourse",
+              follow_redirect: true
+            ) rescue nil
            path = file.path
          else
            path = local_store.path_for(upload)