From cee15d4177bee7f4302ffba66055ab8f90b1c244 Mon Sep 17 00:00:00 2001
From: Osama Sayegh <asooomaasoooma90@gmail.com>
Date: Tue, 20 Jun 2023 11:35:33 +0300
Subject: [PATCH] FIX: Don't error when clicking on a custom link in community
 section (#22174)

---
 .../components/sidebar/common/custom-section.hbs | 16 ++++++++++------
 .../app/lib/sidebar/community-section.js         |  2 ++
 .../discourse/app/lib/sidebar/section.js         |  2 ++
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/sidebar/common/custom-section.hbs b/app/assets/javascripts/discourse/app/components/sidebar/common/custom-section.hbs
index a54e645bc22..a433af1e15d 100644
--- a/app/assets/javascripts/discourse/app/components/sidebar/common/custom-section.hbs
+++ b/app/assets/javascripts/discourse/app/components/sidebar/common/custom-section.hbs
@@ -17,11 +17,15 @@
         @prefixValue={{link.prefixValue}}
         @href={{link.value}}
         @class={{link.linkDragCss}}
-        {{draggable
-          didStartDrag=link.didStartDrag
-          didEndDrag=link.didEndDrag
-          dragMove=link.dragMove
-        }}
+        {{(if
+          this.section.reorderable
+          (modifier
+            "draggable"
+            didStartDrag=link.didStartDrag
+            didEndDrag=link.didEndDrag
+            dragMove=link.dragMove
+          )
+        )}}
       />
     {{else}}
       <Sidebar::SectionLink
@@ -43,7 +47,7 @@
         @currentWhen={{link.currentWhen}}
         @class={{link.linkDragCss}}
         {{(if
-          link.didStartDrag
+          this.section.reorderable
           (modifier
             "draggable"
             didStartDrag=link.didStartDrag
diff --git a/app/assets/javascripts/discourse/app/lib/sidebar/community-section.js b/app/assets/javascripts/discourse/app/lib/sidebar/community-section.js
index bef71704244..36fb28c5714 100644
--- a/app/assets/javascripts/discourse/app/lib/sidebar/community-section.js
+++ b/app/assets/javascripts/discourse/app/lib/sidebar/community-section.js
@@ -44,6 +44,8 @@ export default class CommunitySection {
   @tracked links;
   @tracked moreLinks;
 
+  reorderable = false;
+
   constructor({ section, owner }) {
     setOwner(this, owner);
 
diff --git a/app/assets/javascripts/discourse/app/lib/sidebar/section.js b/app/assets/javascripts/discourse/app/lib/sidebar/section.js
index 260b5ced77d..c388cd3e77a 100644
--- a/app/assets/javascripts/discourse/app/lib/sidebar/section.js
+++ b/app/assets/javascripts/discourse/app/lib/sidebar/section.js
@@ -14,6 +14,8 @@ export default class Section {
   @tracked dragCss;
   @tracked links;
 
+  reorderable = true;
+
   constructor({ section, owner }) {
     setOwner(this, owner);