From ceec11a1534f02bf45f7d86fb6a5cbb3625a3683 Mon Sep 17 00:00:00 2001 From: Dan Ungureanu Date: Mon, 11 Mar 2019 12:06:04 +0200 Subject: [PATCH] FIX: Make post notices invisible to poster. --- app/serializers/post_serializer.rb | 2 +- spec/serializers/post_serializer_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/serializers/post_serializer.rb b/app/serializers/post_serializer.rb index 3f65da2bf3d..f3456648fcc 100644 --- a/app/serializers/post_serializer.rb +++ b/app/serializers/post_serializer.rb @@ -370,7 +370,7 @@ class PostSerializer < BasicPostSerializer end def include_post_notice_type? - return false if scope.user&.id != object.user_id && !scope.user&.has_trust_level?(TrustLevel[2]) + return false if scope.user&.id == object.user_id || !scope.user&.has_trust_level?(TrustLevel[2]) post_notice_type.present? end diff --git a/spec/serializers/post_serializer_spec.rb b/spec/serializers/post_serializer_spec.rb index 4925b79b83d..649f1ec4f67 100644 --- a/spec/serializers/post_serializer_spec.rb +++ b/spec/serializers/post_serializer_spec.rb @@ -193,7 +193,7 @@ describe PostSerializer do it "will not show for poster and TL2+ users" do expect(json_for_user(nil)[:post_notice_type]).to eq(nil) - expect(json_for_user(user)[:post_notice_type]).to eq("returning") + expect(json_for_user(user)[:post_notice_type]).to eq(nil) expect(json_for_user(user_tl1)[:post_notice_type]).to eq(nil) expect(json_for_user(user_tl2)[:post_notice_type]).to eq("returning") end