diff --git a/app/services/staff_action_logger.rb b/app/services/staff_action_logger.rb index 69acc451640..a6354ecb24a 100644 --- a/app/services/staff_action_logger.rb +++ b/app/services/staff_action_logger.rb @@ -134,10 +134,8 @@ class StaffActionLogger })) end - def log_site_text_change(subject, new_text, old_text, opts={}) + def log_site_text_change(subject, new_text=nil, old_text=nil, opts={}) raise Discourse::InvalidParameters.new(:subject) unless subject.present? - raise Discourse::InvalidParameters.new(:new_text) unless new_text.present? - raise Discourse::InvalidParameters.new(:old_text) unless old_text.present? UserHistory.create( params(opts).merge({ action: UserHistory.actions[:change_site_text], subject: subject, diff --git a/spec/services/staff_action_logger_spec.rb b/spec/services/staff_action_logger_spec.rb index d1c7422c7cf..676b899dce9 100644 --- a/spec/services/staff_action_logger_spec.rb +++ b/spec/services/staff_action_logger_spec.rb @@ -176,8 +176,6 @@ describe StaffActionLogger do describe "log_site_text_change" do it "raises an error when params are invalid" do expect { logger.log_site_text_change(nil, 'new text', 'old text') }.to raise_error(Discourse::InvalidParameters) - expect { logger.log_site_text_change('created', nil, 'old text') }.to raise_error(Discourse::InvalidParameters) - expect { logger.log_site_text_change('created', 'new text', nil) }.to raise_error(Discourse::InvalidParameters) end it "creates a new UserHistory record" do