From d06431ba9b3ae6a900ed77d85db7cc8325a4145a Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Wed, 26 Jul 2023 12:45:35 +0200 Subject: [PATCH] DEV: Fix random typos (#22804) A fresh batch of stashed changes :P --- .../javascripts/discourse/app/lib/implicit-injections.js | 2 +- .../javascripts/discourse/app/lib/lightbox/constants.js | 2 +- .../javascripts/discourse/tests/acceptance/d-lightbox-test.js | 2 +- .../discourse/tests/acceptance/implicit-injections-test.js | 2 +- .../javascripts/discourse/tests/helpers/lightbox-helpers.js | 4 ++-- config/locales/client.en.yml | 2 +- .../javascripts/discourse/components/chat-emoji-picker.js | 4 ++-- spec/lib/auth/managed_authenticator_spec.rb | 2 +- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/app/assets/javascripts/discourse/app/lib/implicit-injections.js b/app/assets/javascripts/discourse/app/lib/implicit-injections.js index adc029f6198..711ec882214 100644 --- a/app/assets/javascripts/discourse/app/lib/implicit-injections.js +++ b/app/assets/javascripts/discourse/app/lib/implicit-injections.js @@ -61,7 +61,7 @@ let alreadyRegistered = false; * https://guides.emberjs.com/release/applications/dependency-injection/ * * Incremental migration to newer patterns can be achieved using the `@disableImplicitInjections` - * helper (availble on `discourse/lib/implicit-injections') + * helper (available on `discourse/lib/implicit-injections') */ export function registerDiscourseImplicitInjections() { if (alreadyRegistered) { diff --git a/app/assets/javascripts/discourse/app/lib/lightbox/constants.js b/app/assets/javascripts/discourse/app/lib/lightbox/constants.js index c0cb341d149..04472c0189a 100644 --- a/app/assets/javascripts/discourse/app/lib/lightbox/constants.js +++ b/app/assets/javascripts/discourse/app/lib/lightbox/constants.js @@ -52,7 +52,7 @@ export const SELECTORS = { }; export const LIGHTBOX_APP_EVENT_NAMES = { - // this cannot use dom:clean else #cleanupLightboxes will be called after #setupLighboxes + // this cannot use dom:clean else #cleanupLightboxes will be called after #setupLightboxes CLEAN: "lightbox:clean", CLOSE: "lightbox:close", CLOSED: "lightbox:closed", diff --git a/app/assets/javascripts/discourse/tests/acceptance/d-lightbox-test.js b/app/assets/javascripts/discourse/tests/acceptance/d-lightbox-test.js index 3ca49467f2c..7c42aac7b8d 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/d-lightbox-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/d-lightbox-test.js @@ -960,7 +960,7 @@ acceptance("Experimental Lightbox - conditional buttons", function (needs) { await visit("/t/internationalization-localization/280"); await click(SELECTORS.DEFAULT_ITEM_SELECTOR); - // it doesn not show the newtab or download button + // it does not show the newtab or download button assert.dom(SELECTORS.TAB_BUTTON).doesNotExist(); assert.dom(SELECTORS.DOWNLOAD_BUTTON).doesNotExist(); }); diff --git a/app/assets/javascripts/discourse/tests/acceptance/implicit-injections-test.js b/app/assets/javascripts/discourse/tests/acceptance/implicit-injections-test.js index 9bf6494e5b1..be8c474aa69 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/implicit-injections-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/implicit-injections-test.js @@ -50,7 +50,7 @@ acceptance("Implicit injections shims", function () { assert.strictEqual( newModel.appEvents, "overridden app events", - "overriden app events are passed though when creating from another objects" + "overridden app events are passed though when creating from another objects" ); }); }); diff --git a/app/assets/javascripts/discourse/tests/helpers/lightbox-helpers.js b/app/assets/javascripts/discourse/tests/helpers/lightbox-helpers.js index e3b1c976673..f1c18bf616e 100644 --- a/app/assets/javascripts/discourse/tests/helpers/lightbox-helpers.js +++ b/app/assets/javascripts/discourse/tests/helpers/lightbox-helpers.js @@ -105,7 +105,7 @@ export const LIGHTBOX_IMAGE_FIXTURES = { }; export function generateLightboxObject() { - const trimmedLighboxItem = Object.keys(LIGHTBOX_IMAGE_FIXTURES.first).reduce( + const trimmedLightboxItem = Object.keys(LIGHTBOX_IMAGE_FIXTURES.first).reduce( (acc, key) => { if (key !== "height" && key !== "width" && key !== "alt") { acc[key] = LIGHTBOX_IMAGE_FIXTURES.first[key]; @@ -116,7 +116,7 @@ export function generateLightboxObject() { ); return { - items: [{ ...trimmedLighboxItem }], + items: [{ ...trimmedLightboxItem }], startingIndex: 0, callbacks: {}, options: {}, diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml index baf90338b33..3b3a617c307 100644 --- a/config/locales/client.en.yml +++ b/config/locales/client.en.yml @@ -4819,7 +4819,7 @@ en: update: Update a topic. Change the title, category, tags, status, archetype, featured_link etc. delete: Delete a topic. read_lists: Read topic lists like top, new, latest, etc. RSS is also supported. - status: "Update a topic's status. Status: closed, archive, visisble, pinned. Enabled: true, false. Specify a category_id here and in the request payload to only allow status changes on topics in that category." + status: "Update a topic's status. Status: closed, archive, visible, pinned. Enabled: true, false. Specify a category_id here and in the request payload to only allow status changes on topics in that category." posts: edit: Edit any post or a specific one. delete: Delete a post. diff --git a/plugins/chat/assets/javascripts/discourse/components/chat-emoji-picker.js b/plugins/chat/assets/javascripts/discourse/components/chat-emoji-picker.js index fb990119256..482472b21da 100644 --- a/plugins/chat/assets/javascripts/discourse/components/chat-emoji-picker.js +++ b/plugins/chat/assets/javascripts/discourse/components/chat-emoji-picker.js @@ -379,7 +379,7 @@ export default class ChatEmojiPicker extends Component { } schedule("afterRender", () => { - const firsEmoji = document.querySelector( + const firstEmoji = document.querySelector( `.chat-emoji-picker__section[data-section="${section}"] .emoji:nth-child(1)` ); @@ -388,7 +388,7 @@ export default class ChatEmojiPicker extends Component { ...document.querySelectorAll( `.chat-emoji-picker__section[data-section="${section}"] .emoji` ), - ].find((emoji) => emoji.offsetTop > firsEmoji.offsetTop) || firsEmoji; + ].find((emoji) => emoji.offsetTop > firstEmoji.offsetTop) || firstEmoji; targetEmoji.focus(); diff --git a/spec/lib/auth/managed_authenticator_spec.rb b/spec/lib/auth/managed_authenticator_spec.rb index 940be5776b1..ab9b5d7da61 100644 --- a/spec/lib/auth/managed_authenticator_spec.rb +++ b/spec/lib/auth/managed_authenticator_spec.rb @@ -372,7 +372,7 @@ RSpec.describe Auth::ManagedAuthenticator do expect(result.user).to eq(nil) end - it "does not match if default match_by_username not overriden" do + it "does not match if default match_by_username not overridden" do SiteSetting.username_change_period = 0 authenticator = Class